Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1308504

Re: [PATCH v2 1/1] net: netlink: Fix multicast group storage allocation for families with more than one groups

Show all headers | View raw

From: Matti Vaittinen <matti.vaittinen@nokia.com>
Date: Wed, 13 Jan 2016 09:54:12 +0200

> Hello again,
> 
>       Second version, Fixed the 'off by one' bug spotted by David.
> 
>       Br.
>         Matti Vaittinen
> 
> Multicast groups are stored in global buffer. Check for needed buffer size
> incorrectly compares buffer size to first id for family. This means that
> for families with more than one mcast id one may allocate too small buffer
> and end up writing rest of the groups to some unallocated memory. Fix the
> buffer size check to compare allocated space to last mcast id for the
> family.
> 
> Tested on ARM using kernel 3.14
> 
> Signed-off-by: Matti Vaittinen <matti.vaittinen@nokia.com>

I inadvertantly applied your original patch, so I'll just fix
the off-by-one error with a seperate commit.

Sorry for the confusion and thanks for fixing this.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/1] net: netlink: Fix multicast group storage allocation  for families with more than one groups Matti Vaittinen <matti.vaittinen@nokia.com> - 2016-01-13 07:50 +0100
  Re: [PATCH v2 1/1] net: netlink: Fix multicast group storage  allocation for families with more than one groups David Miller <davem@davemloft.net> - 2016-01-13 16:30 +0100

csiph-web