Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1308417
| From | David Sterba <dsterba@suse.cz> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [patch] Btrfs: clean up an error code in btrfs_init_space_info() |
| Date | 2016-01-13 14:40 +0100 |
| Message-ID | <qQtOy-mT-17@gated-at.bofh.it> (permalink) |
| References | <qQsIO-84i-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Jan 13, 2016 at 03:21:17PM +0300, Dan Carpenter wrote:
> If we return 1 here, then the caller treats it as an error and returns
> -EINVAL. It causes a static checker warning to treat positive returns
> as an error.
>
> Fixes: 1aba86d67f34 ('Btrfs: fix easily get into ENOSPC in mixed case')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> I would appreciate a little review here. This patch doesn't change
> behavior, but it's possible that we had intended to do something else.
No, it makes sense to switch it to -EINVAL. Thanks.
Reviewed-by: David Sterba <dsterba@suse.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[patch] Btrfs: clean up an error code in btrfs_init_space_info() Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-13 13:30 +0100 Re: [patch] Btrfs: clean up an error code in btrfs_init_space_info() David Sterba <dsterba@suse.cz> - 2016-01-13 14:40 +0100 Re: [patch] Btrfs: clean up an error code in btrfs_init_space_info() Liu Bo <bo.li.liu@oracle.com> - 2016-01-13 19:20 +0100
csiph-web