Re: [PATCH V2 6/6] regulator: max77620: add regulator driver for max77620/max20024

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2 6/6] regulator: max77620: add regulator driver for max77620/max20024
Date	2016-01-13 13:40 +0100
Message-ID	<qQsSu-89F-5@gated-at.bofh.it> (permalink)
References	(1 earlier) <qQ3r4-7nB-13@gated-at.bofh.it> <qQiq6-Ls-3@gated-at.bofh.it> <qQsfL-7Bq-3@gated-at.bofh.it> <qQsfL-7Bq-1@gated-at.bofh.it> <qQsz9-7YE-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Jan 13, 2016 at 05:35:33PM +0530, Laxman Dewangan wrote:
> On Wednesday 13 January 2016 05:27 PM, Mark Brown wrote:

> >>Something below. This will do the pre configuration before
> >>regulator_register happena dn machine constraint sets.
> >>I can not use the init_data->regulator_init() as I need to have the init
> >>data passed to the driver.

> >Why do you have this requirement?

> This is require to
> - configure FPS_SRC based on platform data for each rail,
>     - If FPS_SRC enabled then enable it always.
>     - If FPS_SRC is disabled (NONE) then based on init data constraint,
>       set it to desired state.

What is FPS_SRC and why is it set from init_data?  A driver should never
be looking at init_data.

> - Power mode and slew rate init based on default configuration from the
> register if platform does not want to set it.

Same here, why is init_data needed here?

Thread

[PATCH V2 6/6] regulator: max77620: add regulator driver for max77620/max20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-12 10:30 +0100
  Re: [PATCH V2 6/6] regulator: max77620: add regulator driver for  max77620/max20024 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-13 02:30 +0100
    Re: [PATCH V2 6/6] regulator: max77620: add regulator driver for  max77620/max20024 Mark Brown <broonie@kernel.org> - 2016-01-13 13:00 +0100
      Re: [PATCH V2 6/6] regulator: max77620: add regulator driver for  max77620/max20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-13 13:20 +0100
        Re: [PATCH V2 6/6] regulator: max77620: add regulator driver for  max77620/max20024 Mark Brown <broonie@kernel.org> - 2016-01-13 13:40 +0100
          Re: [PATCH V2 6/6] regulator: max77620: add regulator driver for  max77620/max20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-13 13:50 +0100
            Re: [PATCH V2 6/6] regulator: max77620: add regulator driver for  max77620/max20024 Mark Brown <broonie@kernel.org> - 2016-01-13 14:10 +0100
              Re: [PATCH V2 6/6] regulator: max77620: add regulator driver for  max77620/max20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-13 14:30 +0100
                Re: [PATCH V2 6/6] regulator: max77620: add regulator driver for  max77620/max20024 Mark Brown <broonie@kernel.org> - 2016-01-13 15:30 +0100
                Re: [PATCH V2 6/6] regulator: max77620: add regulator driver for  max77620/max20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-13 16:00 +0100
                Re: [PATCH V2 6/6] regulator: max77620: add regulator driver for  max77620/max20024 Mark Brown <broonie@kernel.org> - 2016-01-13 17:00 +0100
    Re: [PATCH V2 6/6] regulator: max77620: add regulator driver for  max77620/max20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-13 13:00 +0100

csiph-web