Re: [PATCH] perf tools: Do not show trace command if it's not compiled in

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] perf tools: Do not show trace command if it's not compiled in
Date	2016-01-13 11:50 +0100
Message-ID	<qQra2-6Tj-19@gated-at.bofh.it> (permalink)
References	<qHPbz-2Zl-11@gated-at.bofh.it> <qQ5jc-cc-27@gated-at.bofh.it> <qQ8h3-2fU-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Em Tue, Jan 12, 2016 at 12:23:41PM +0100, Ingo Molnar escreveu:
> > 
> > * Jiri Olsa <jolsa@kernel.org> wrote:
> > 
> > > The trace command still appears in help message when you
> > > run simple 'perf' command.
> > > 
> > > It's because the generate-cmdlist.sh does not care about the
> > > HAVE_LIBAUDIT_SUPPORT dependency of trace command and puts
> > > it into generated common_cmds array.
> > > 
> > > Wrapping trace command under HAVE_LIBAUDIT_SUPPORT dependency,
> > > which will exclude it from common_cmds array if HAVE_LIBAUDIT_SUPPORT
> > > is not set.
> > 
> > Btw., would it make sense to still list them, but denote them as '[NOT BUILT IN]':
> 
> Yeah, just like we have:
> 
>   $ make NO_DWARF=1 O=/tmp/build/perf -C tools/perf/ install
>   make: Entering directory '/home/git/linux/tools/perf'
>     BUILD:   Doing 'make -j4' parallel build
>   config/Makefile:328: DWARF support is off, BPF prologue is disabled
>     SUBDIR   Documentation
>     ASCIIDOC /tmp/build/perf/perf-diff.xml
>     CC       /tmp/build/perf/util/abspath.o
>   <SNIP>
> 
>   $ perf record -h vm build
> 
>    Usage: perf record [<options>] [<command>]
>       or: perf record [<options>] -- <command> [<options>]
> 
>       -B, --no-buildid        do not collect buildids in perf.data
>       -N, --no-buildid-cache  do not update the buildid cache
>           --vmlinux <file>    vmlinux pathname
>                               (not built-in because NO_DWARF=1)

Very nice!

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] perf tools: Do not show trace command if it's not  compiled in Ingo Molnar <mingo@kernel.org> - 2016-01-12 12:30 +0100
  Re: [PATCH] perf tools: Do not show trace command if it's not  compiled in Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-12 15:40 +0100
    Re: [PATCH] perf tools: Do not show trace command if it's not  compiled in Ingo Molnar <mingo@kernel.org> - 2016-01-13 11:50 +0100

csiph-web