Re: [RFC 6/6] perf build: Introduce FEATURES_DUMP make variable

From	"Wangnan (F)" <wangnan0@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [RFC 6/6] perf build: Introduce FEATURES_DUMP make variable
Date	2016-01-13 11:20 +0100
Message-ID	<qQqH0-6FS-23@gated-at.bofh.it> (permalink)
References	(1 earlier) <qPImD-1cN-35@gated-at.bofh.it> <qQ3r4-7nB-23@gated-at.bofh.it> <qQpKX-60h-15@gated-at.bofh.it> <qQqdZ-6f4-5@gated-at.bofh.it> <qQqxl-6Bo-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 2016/1/13 18:03, Jiri Olsa wrote:
> On Wed, Jan 13, 2016 at 05:46:13PM +0800, Wangnan (F) wrote:
>
> SNIP
>
>>> I'll try to check on that.. does this patch help to improve
>>> the current speed or do you need to solve this to get substantial
>>> speedup?
>> I'm working on it. I have already done it, but still have some
>> problem. On some machine 'make_static' test target lost
>> '-liberty -lz' in its linker options. Seems something wrong in
>> this part:
>>
>> ifeq ($(feature-libbfd), 1)
>>    EXTLIBS += -lbfd
>>
>>    # call all detections now so we get correct
>>    # status in VF output
>>    $(call feature_check,liberty)
>>    $(call feature_check,liberty-z)
>>    $(call feature_check,cplus-demangle)
>>
>>    ifeq ($(feature-liberty), 1)
>>      EXTLIBS += -liberty
>>    else
>>      ifeq ($(feature-liberty-z), 1)
>>        EXTLIBS += -liberty -lz
>>      endif
>>    endif
>> endif
> IIRC we had issues with this before.. different systems
> provide those libs in different way, like:
>    2cf9040714f3 perf tools: Fix bfd dependency libraries detection
>
> you might want to check feature detection code if it gets
> built properly on your system

No this problem. There's no feature-libiberty and feature-libiberty-z in
output feature-dump file. This is the key reason.

> jirka

Thread

[PATCH 0/6] tools: Add clean targets for tools directory Jiri Olsa <jolsa@kernel.org> - 2016-01-11 12:00 +0100
  [RFC 6/6] perf build: Introduce FEATURES_DUMP make variable Jiri Olsa <jolsa@kernel.org> - 2016-01-11 12:00 +0100
    Re: [RFC 6/6] perf build: Introduce FEATURES_DUMP make variable "Wangnan (F)" <wangnan0@huawei.com> - 2016-01-12 10:30 +0100
      Re: [RFC 6/6] perf build: Introduce FEATURES_DUMP make variable Jiri Olsa <jolsa@redhat.com> - 2016-01-13 10:20 +0100
        Re: [RFC 6/6] perf build: Introduce FEATURES_DUMP make variable "Wangnan (F)" <wangnan0@huawei.com> - 2016-01-13 10:50 +0100
          Re: [RFC 6/6] perf build: Introduce FEATURES_DUMP make variable Jiri Olsa <jolsa@redhat.com> - 2016-01-13 11:10 +0100
            Re: [RFC 6/6] perf build: Introduce FEATURES_DUMP make variable "Wangnan (F)" <wangnan0@huawei.com> - 2016-01-13 11:20 +0100
            Re: [RFC 6/6] perf build: Introduce FEATURES_DUMP make variable "Wangnan (F)" <wangnan0@huawei.com> - 2016-01-13 13:10 +0100
              Re: [RFC 6/6] perf build: Introduce FEATURES_DUMP make variable Jiri Olsa <jolsa@redhat.com> - 2016-01-13 13:20 +0100
  [PATCH 4/6] perf tools: Add missing sources in perf's MANIFEST Jiri Olsa <jolsa@kernel.org> - 2016-01-11 12:00 +0100
    [tip:perf/urgent] perf tools: Add missing sources to perf'  s MANIFEST tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-01-12 11:10 +0100
  [PATCH 1/6] tools: Add clean targets for tools directory Jiri Olsa <jolsa@kernel.org> - 2016-01-11 12:00 +0100
    [tip:perf/urgent] tools: Add clean targets for tools directory tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-01-12 11:10 +0100
  [PATCH 2/6] tools bpf: Add *.cmd files clean up Jiri Olsa <jolsa@kernel.org> - 2016-01-11 12:00 +0100
    [tip:perf/urgent] tools bpf: Add *.cmd files clean up tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-01-12 11:10 +0100

csiph-web