Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1308172
| From | Marc Zyngier <marc.zyngier@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2 03/10] irqchip,GICv3,ACPI: Add redistributor support via GICC structures. |
| Date | 2016-01-13 09:40 +0100 |
| Message-ID | <qQp8e-5ru-17@gated-at.bofh.it> (permalink) |
| References | <qGFnY-7mN-3@gated-at.bofh.it> <qGFnY-7mN-1@gated-at.bofh.it> <qQ5VU-FV-27@gated-at.bofh.it> <qQaiT-3xk-25@gated-at.bofh.it> <qQiT8-Zm-5@gated-at.bofh.it> |
| Organization | ARM Ltd |
On 13/01/16 01:52, Hanjun Guo wrote: > > > On 2016/1/13 0:45, Tomasz Nowicki wrote: >> On 12.01.2016 13:03, Marc Zyngier wrote: >> >> > + typer = readq_relaxed(redist_base + GICR_TYPER); >> > + /* don't map reserved page as it's buggy to access it */ >> > + size = (typer & GICR_TYPER_VLPIS) ? SZ_64K * 3 : SZ_64K * 2; >> >> [...] >> >>> Also, please map the whole region for the >>> redistributor as we have on the DT side (4 64kB pages for VLPIS capable >>> redistributors). >> >> Hanjun, is it something you had problem with? > > Yes, for D02, it use 3 64kB pages for GICv4, it removed the reserved > page. In DT case, it has "stride" binding so it can support no standard > cases, seems that we can introduce "stride" for ACPI too. I don't think there is any need for that, assuming this system only exposes its redistributors via the ACPI GICC structure. In which case, I don't think it hurts to have overlapping mappings: For redistributors A and B, we never touch A[3] (the reserved page), but we will access B[0]. Thanks, M. -- Jazz is not dead. It just smells funny...
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH V2 03/10] irqchip,GICv3,ACPI: Add redistributor support via GICC structures. Marc Zyngier <marc.zyngier@arm.com> - 2016-01-12 13:10 +0100
Re: [PATCH V2 03/10] irqchip,GICv3,ACPI: Add redistributor support via GICC structures. Hanjun Guo <hanjun.guo@linaro.org> - 2016-01-12 16:10 +0100
Re: [PATCH V2 03/10] irqchip,GICv3,ACPI: Add redistributor support via GICC structures. Marc Zyngier <marc.zyngier@arm.com> - 2016-01-12 17:20 +0100
Re: [PATCH V2 03/10] irqchip,GICv3,ACPI: Add redistributor support via GICC structures. Tomasz Nowicki <tn@semihalf.com> - 2016-01-12 18:20 +0100
Re: [PATCH V2 03/10] irqchip,GICv3,ACPI: Add redistributor support via GICC structures. Tomasz Nowicki <tn@semihalf.com> - 2016-01-12 17:50 +0100
Re: [PATCH V2 03/10] irqchip,GICv3,ACPI: Add redistributor support via GICC structures. Hanjun Guo <hanjun.guo@linaro.org> - 2016-01-13 03:00 +0100
Re: [PATCH V2 03/10] irqchip,GICv3,ACPI: Add redistributor support via GICC structures. Marc Zyngier <marc.zyngier@arm.com> - 2016-01-13 09:40 +0100
Re: [PATCH V2 03/10] irqchip,GICv3,ACPI: Add redistributor support via GICC structures. Hanjun Guo <hanjun.guo@linaro.org> - 2016-01-13 10:20 +0100
csiph-web