[PATCH 2/4] irqchip: atmel-aic: Fix wrong bit operation for IRQ priority

From	Milo Kim <milo.kim@ti.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/4] irqchip: atmel-aic: Fix wrong bit operation for IRQ priority
Date	2016-01-13 08:30 +0100
Message-ID	<qQo2u-4Jn-13@gated-at.bofh.it> (permalink)
References	<qQo2u-4Jn-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Atmel AIC has common structure for SMR (Source Mode Register).

  bit[6:5] Interrupt source type
  bit[2:0] Priority level
  Other bits are unused.

To update new priority value, bit[2:0] should be cleared first and then
new priority level can be written. However, aic_common_set_priority()
helper clears source type bits instead of priority bits.
This patch fixes wrong mask bit operation.

Fixes: b1479ebb7720 ("irqchip: atmel-aic: Add atmel AIC/AIC5 drivers")
Signed-off-by: Milo Kim <milo.kim@ti.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Ludovic Desroches <ludovic.desroches@atmel.com>
Cc: Nicholas Ferre <nicolas.ferre@atmel.com>
Cc: linux-kernel@vger.kernel.org
Cc: <stable@vger.kernel.org> #v3.17+
---
 drivers/irqchip/irq-atmel-aic-common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-atmel-aic-common.c b/drivers/irqchip/irq-atmel-aic-common.c
index 2f2d73e..661840b 100644
--- a/drivers/irqchip/irq-atmel-aic-common.c
+++ b/drivers/irqchip/irq-atmel-aic-common.c
@@ -86,7 +86,7 @@ int aic_common_set_priority(int priority, unsigned *val)
 	    priority > AT91_AIC_IRQ_MAX_PRIORITY)
 		return -EINVAL;
 
-	*val &= AT91_AIC_PRIOR;
+	*val &= ~AT91_AIC_PRIOR;
 	*val |= priority;
 
 	return 0;
-- 
2.7.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 2/4] irqchip: atmel-aic: Fix wrong bit operation for IRQ priority Milo Kim <milo.kim@ti.com> - 2016-01-13 08:30 +0100

csiph-web