Re: [PATCH 1/1] net: netlink: Fix multicast group storage allocation for families with more than one groups

From	Matti Vaittinen <matti.vaittinen@nokia.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] net: netlink: Fix multicast group storage allocation for families with more than one groups
Date	2016-01-13 07:50 +0100
Message-ID	<qQnpL-4eY-13@gated-at.bofh.it> (permalink)
References	<qPIPE-1Dk-15@gated-at.bofh.it> <qQeZd-6Mv-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello David & others,

On Tue, Jan 12, 2016 at 04:42:11PM -0500, EXT David Miller wrote:
> But I think your change has an off-by-one bug:
> 
> From: Matti Vaittinen <matti.vaittinen@nokia.com>
> > -		if (id >= mc_groups_longs * BITS_PER_LONG) {
> > +		if (id + n_groups >= mc_groups_longs * BITS_PER_LONG) {
> 
> I think this needs to be "id + n_groups > ".  Consider the existing,
> working, case of "n_groups == 1".  Now you're adding '1' and therefore
> the test needs to be adjusted from >= to >.

Absolutely. I did patch v2.

Br.
    Matti Vaittinen

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] net: netlink: Fix multicast group storage allocation for  families with more than one groups Matti Vaittinen <matti.vaittinen@nokia.com> - 2016-01-11 12:30 +0100
  Re: [PATCH 1/1] net: netlink: Fix multicast group storage  allocation for families with more than one groups David Miller <davem@davemloft.net> - 2016-01-12 22:50 +0100
    Re: [PATCH 1/1] net: netlink: Fix multicast group storage allocation  for families with more than one groups Matti Vaittinen <matti.vaittinen@nokia.com> - 2016-01-13 07:50 +0100

csiph-web