Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1308021

Re: [PATCH] bugfix dax fault page should be no cache

From "Chenjie (K)" <chenjie6@huawei.com>
Newsgroups linux.kernel
Subject Re: [PATCH] bugfix dax fault page should be no cache
Date 2016-01-13 04:50 +0100
Message-ID <qQkBA-2i0-15@gated-at.bofh.it> (permalink)
References <qPY81-3Kg-5@gated-at.bofh.it> <qQ6Ih-11c-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


The DAX means Direct Access for files,if the pages have cache,
the file is not direct access. But in normal condition,
we can not find the problem directly.

  In our case, we use ext2 filesystem with dax on the reserved mem.
we mmap the file and write some things ,the file is not changed immediately.

this is the wrong place to change that attribute:
	Do you mean
add
	ext4_file_mmap/ext2_file_mmap

	if (IS_DAX(file_inode(file))) {
		vma->vm_ops = &ext4_dax_vm_ops;
		vma->vm_flags |= VM_MIXEDMAP;
+	vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot);
	} else {
like this ???

On 2016/1/12 20:51, Matthew Wilcox wrote:
> On Tue, Jan 12, 2016 at 07:43:45PM +0800, chenjie6@huawei.com wrote:
>> From: chenjie <chenjie6@huawei.com>
>>
>> We show the pte:
>> 	*pte=01600000159c8fd3
>> The page should be no_cache attr,it will be better.
>
> I disagree.  What data do you have to show that the WC attribute would
> be better than WB?
>
> Even if we agree to that, this is the wrong place to change that
> attribute, so the patch is NAKed.  But you need more than "it will
> be better".
>
> .
>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] bugfix dax fault page should be no cache <chenjie6@huawei.com> - 2016-01-12 04:50 +0100
  Re: [PATCH] bugfix dax fault page should be no cache Matthew Wilcox <willy@linux.intel.com> - 2016-01-12 14:00 +0100
    Re: [PATCH] bugfix dax fault page should be no cache "Chenjie (K)" <chenjie6@huawei.com> - 2016-01-13 04:50 +0100
      Re: [PATCH] bugfix dax fault page should be no cache Matthew Wilcox <willy@linux.intel.com> - 2016-01-13 17:40 +0100

csiph-web