Re: [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node

From	Andy Gross <andy.gross@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node
Date	2016-01-12 23:30 +0100
Message-ID	<qQfBU-7kg-31@gated-at.bofh.it> (permalink)
References	<qQ7uF-1zT-3@gated-at.bofh.it> <qQ7uH-1zT-19@gated-at.bofh.it> <qQ7O1-1Z5-15@gated-at.bofh.it> <qQ7XI-23e-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jan 12, 2016 at 02:18:53PM +0000, Srinivas Kandagatla wrote:
> 
> 
> On 12/01/16 14:00, Arnd Bergmann wrote:
> >On Tuesday 12 January 2016 13:46:52 Srinivas Kandagatla wrote:
> >>To be consistent with other nodes move sdhci node under the soc node,
> >>rather than using lable references.
> >>
> >>Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> >>
> >
> >Maybe remove the label as well if you are no longer using it?
> Label "sdhc_1" in this case is used in aliases node.
> 
> >
> My understanding so far was qcom specific dt want to use hierarchical dt
> nodes in the board files, but this brings the question of should we delete
> all the unused labels.
> 
> IMO, some unused labels are harmless and would give more consistency to the
> reader, removing them might not add great value.
> 
> Andy/Stephen, any comments?

I tend to lean towards leaving the labels in.  But at the same time we don't
want to get cluttered with unused labels.  That said, perhaps If the label
makes things more understandable, then leave them in.  Otherwise, they really
have no use.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-01-12 14:50 +0100
  Re: [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node Arnd Bergmann <arnd@arndb.de> - 2016-01-12 15:10 +0100
    Re: [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc  node Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-01-12 15:20 +0100
      Re: [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node Arnd Bergmann <arnd@arndb.de> - 2016-01-12 16:00 +0100
      Re: [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc  node Andy Gross <andy.gross@linaro.org> - 2016-01-12 23:30 +0100

csiph-web