Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1307885

Re: [PATCH v2 2/3] x86: drop a comment left over from X86_OOSTORE

From One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Newsgroups linux.kernel
Subject Re: [PATCH v2 2/3] x86: drop a comment left over from X86_OOSTORE
Date 2016-01-12 23:30 +0100
Message-ID <qQfBU-7kg-15@gated-at.bofh.it> (permalink)
References <qQfsd-7eN-3@gated-at.bofh.it> <qQfse-7eN-9@gated-at.bofh.it>
Organization Intel Corporation

Show all headers | View raw


On Wed, 13 Jan 2016 00:10:19 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> The comment about wmb being non-nop is a left over from before commit
> 09df7c4c8097 ("x86: Remove CONFIG_X86_OOSTORE").
> 
> It makes no sense now: if you have an SMP system with out of order
> stores, making wmb not a nop will not help.

There were never any IDT Winchip systems with SMP support, and they were
the one system that could enable OOSTORE (and it was worth up to 30% on
some workloads). The fencing it had was just for DMA devices.

Alan

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH v2 2/3] x86: drop a comment left over from X86_OOSTORE "Michael S. Tsirkin" <mst@redhat.com> - 2016-01-12 23:20 +0100
  Re: [PATCH v2 2/3] x86: drop a comment left over from X86_OOSTORE One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-01-12 23:30 +0100

csiph-web