Re: [PATCH 3/3] bonding: make device count build-time configurable

From	Bjørn Mork <bjorn@mork.no>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] bonding: make device count build-time configurable
Date	2016-01-12 22:50 +0100
Message-ID	<qQeZd-6Mv-47@gated-at.bofh.it> (permalink)
References	<qQ5Mf-nk-35@gated-at.bofh.it> <qQa9d-3tC-15@gated-at.bofh.it> <qQaVB-40U-27@gated-at.bofh.it> <qQe38-69u-13@gated-at.bofh.it>
Organization	m

Show all headers | View raw

David Miller <davem@davemloft.net> writes:
> From: Lubomir Rintel <lkundrak@v3.sk>
> Date: Tue, 12 Jan 2016 18:19:49 +0100
>
>> It's still an improvement to let the distributions decide if they're
>> keeping "ip link add" broken or possibly affecting the scripts.
>
> That it is "broken" is your opinion.
>
> Document the behavior.  It is not broken if the user is told to be
> mindful of what devices are created by default.
>
> There is way too much downside to changing this.

Besides, distributions or admins can already change that behaviour if
they consider it "broken", using the existing module parameter:

 # echo "options bonding max_bonds=0" >/etc/modprobe.d/bonding.conf
 # rmmod bonding
 # ip link add bond0 type bond
 (no error here)

This method should be well known and understood by most users, contrary
to some odd CONFIG_ build time setting.


Bjørn

Thread

[PATCH 3/3] bonding: make device count build-time configurable Lubomir Rintel <lkundrak@v3.sk> - 2016-01-12 13:00 +0100
  Re: [PATCH 3/3] bonding: make device count build-time configurable Jay Vosburgh <jay.vosburgh@canonical.com> - 2016-01-12 17:40 +0100
    Re: [PATCH 3/3] bonding: make device count build-time configurable Lubomir Rintel <lkundrak@v3.sk> - 2016-01-12 18:30 +0100
      Re: [PATCH 3/3] bonding: make device count build-time configurable Jay Vosburgh <jay.vosburgh@canonical.com> - 2016-01-12 20:40 +0100
      Re: [PATCH 3/3] bonding: make device count build-time configurable David Miller <davem@davemloft.net> - 2016-01-12 21:50 +0100
        Re: [PATCH 3/3] bonding: make device count build-time configurable Bjørn Mork <bjorn@mork.no> - 2016-01-12 22:50 +0100
    Re: [PATCH 3/3] bonding: make device count build-time configurable David Miller <davem@davemloft.net> - 2016-01-12 21:50 +0100

csiph-web