Re: [PATCH v3 1/2] PCI: generic: Refactor code to enable reuse by other drivers.

From	Will Deacon <will.deacon@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/2] PCI: generic: Refactor code to enable reuse by other drivers.
Date	2016-01-12 19:10 +0100
Message-ID	<qQbyj-4DG-41@gated-at.bofh.it> (permalink)
References	<qOP6N-5zU-5@gated-at.bofh.it> <qOP6N-5zU-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jan 08, 2016 at 03:59:12PM -0800, David Daney wrote:
> From: David Daney <david.daney@cavium.com>
> 
> No change in functionality.
> 
> Move structure definitions into a separate header file.  Move common
> code to new file with Kconfig machinery to build it.  Split probe
> function in to two parts:
> 
>    - a small driver specific probe function (gen_pci_probe)
> 
>    - a common probe that can be used by other drivers
>      (pci_host_common_probe)
> 
> Signed-off-by: David Daney <david.daney@cavium.com>
> ---
>  MAINTAINERS                         |   1 +
>  drivers/pci/host/Kconfig            |   4 +
>  drivers/pci/host/Makefile           |   1 +
>  drivers/pci/host/pci-host-common.c  | 194 ++++++++++++++++++++++++++++++++++++
>  drivers/pci/host/pci-host-common.h  |  56 +++++++++++
>  drivers/pci/host/pci-host-generic.c | 190 +----------------------------------
>  6 files changed, 260 insertions(+), 186 deletions(-)
>  create mode 100644 drivers/pci/host/pci-host-common.c
>  create mode 100644 drivers/pci/host/pci-host-common.h

Looks fine to me:

  Acked-by: Will Deacon <will.deacon@arm.com>

Will

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/2] PCI: generic: Refactor code to enable reuse by other drivers. David Daney <ddaney.cavm@gmail.com> - 2016-01-09 01:00 +0100
  Re: [PATCH v3 1/2] PCI: generic: Refactor code to enable reuse by  other drivers. Will Deacon <will.deacon@arm.com> - 2016-01-12 19:10 +0100

csiph-web