Re: [GIT PULL] regulator updates for v4.5

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [GIT PULL] regulator updates for v4.5
Date	2016-01-12 19:20 +0100
Message-ID	<qQbHY-4HB-17@gated-at.bofh.it> (permalink)
References	<qQ3U6-7AD-7@gated-at.bofh.it> <qQbeW-4fh-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Jan 12, 2016 at 09:48:54AM -0800, Linus Torvalds wrote:

> Nope. No can do.

> I get a build error:

>   drivers/regulator/max8973-regulator.c:506:4: error:
> ‘THERMAL_DEVICE_EVENT_THRESHOLD’ undeclared

> and grepping around for this that is not some merge error: even in
> your tree (before being merged into mine), that thing simply does not
> exist except in that one place:

>   [torvalds@i7 linux]$ git grep THERMAL_DEVICE_EVENT_THRESHOLD 2986a09d8
>   2986a09d8:drivers/regulator/max8973-regulator.c:
>    THERMAL_DEVICE_EVENT_THRESHOLD);

> and that's it.

> So this tree clearly can never have worked, and never have compiled.

> Consider yourself cursed at.

Ugh, right.  It builds fine in -next because that has been introduced in
the thermal tree and that gets merged first (the code had been there), I
hadn't updated the local test configs and for some reason the kernelci
results got lost in the noise.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[GIT PULL] regulator updates for v4.5 Mark Brown <broonie@kernel.org> - 2016-01-12 11:00 +0100
  Re: [GIT PULL] regulator updates for v4.5 Linus Torvalds <torvalds@linux-foundation.org> - 2016-01-12 18:50 +0100
    Re: [GIT PULL] regulator updates for v4.5 Linus Torvalds <torvalds@linux-foundation.org> - 2016-01-12 19:00 +0100
      Re: [GIT PULL] regulator updates for v4.5 Mark Brown <broonie@kernel.org> - 2016-01-12 19:30 +0100
    Re: [GIT PULL] regulator updates for v4.5 Mark Brown <broonie@kernel.org> - 2016-01-12 19:20 +0100

csiph-web