Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1309460

Re: [PATCH] fsl/fman: Delete one function call "put_device" in dtsec_config()

Show all headers | View raw

On Thu, Jan 14, 2016 at 04:00:46PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 14 Jan 2016 15:46:28 +0100
> 
> The Coccinelle semantic patch script "deref_null.cocci" pointed a problem
> out in the implementation of the function "dtsec_config".
> 
> A null pointer was assigned to the data structure member "tbiphy" of the
> variable "dtsec" if a matching device was not found.
> A call of the function "put_device" was unnecessary then because
> a previous call of the function "get_device" was not triggered.
> Thus remove the function call "put_device" after the printing of the
> desired error message.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Fixes: 57ba4c9b56d8 ("fsl/fman: Add FMan MAC support")
Reviewd-by: Andrew Lunn <andrew@lunn.ch>

	    Andrew
> ---
>  drivers/net/ethernet/freescale/fman/fman_dtsec.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fman/fman_dtsec.c b/drivers/net/ethernet/freescale/fman/fman_dtsec.c
> index 6b1261c..7c92eb8 100644
> --- a/drivers/net/ethernet/freescale/fman/fman_dtsec.c
> +++ b/drivers/net/ethernet/freescale/fman/fman_dtsec.c
> @@ -1434,7 +1434,6 @@ struct fman_mac *dtsec_config(struct fman_mac_params *params)
>  	dtsec->tbiphy = of_phy_find_device(params->internal_phy_node);
>  	if (!dtsec->tbiphy) {
>  		pr_err("of_phy_find_device (TBI PHY) failed\n");
> -		put_device(&dtsec->tbiphy->mdio.dev);
>  		goto err_dtsec_drv_param;
>  	}
>  
> -- 
> 2.6.3
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

fsl/fman: Clarification for implementation details in dtsec_config() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-13 22:30 +0100
  Re: fsl/fman: Clarification for implementation details in  dtsec_config() Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-13 22:40 +0100
    Re: fsl/fman: Clarification for implementation details in  dtsec_config() Andrew Lunn <andrew@lunn.ch> - 2016-01-13 23:10 +0100
      [PATCH] fsl/fman: Delete one function call "put_device" in  dtsec_config() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-14 16:10 +0100
        Re: [PATCH] fsl/fman: Delete one function call "put_device" in  dtsec_config() Andrew Lunn <andrew@lunn.ch> - 2016-01-14 17:30 +0100
        Re: [PATCH] fsl/fman: Delete one function call "put_device" in  dtsec_config() David Miller <davem@davemloft.net> - 2016-01-14 23:00 +0100

csiph-web