Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1309296

RE: [PATCH net-next 08/10] bus: mvenus-mbus: Fix size test for mvebu_mbus_get_dram_win_info

Show all headers | View raw

From: Gregory CLEMENT
> Sent: 12 January 2016 19:11
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
>  drivers/bus/mvebu-mbus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c
> index 3d1c0c3880ec..214bb964165b 100644
> --- a/drivers/bus/mvebu-mbus.c
> +++ b/drivers/bus/mvebu-mbus.c
> @@ -964,7 +964,7 @@ int mvebu_mbus_get_dram_win_info(phys_addr_t phyaddr, u8 *target, u8 *attr)
>  	for (i = 0; i < dram->num_cs; i++) {
>  		const struct mbus_dram_window *cs = dram->cs + i;
> 
> -		if (cs->base <= phyaddr && phyaddr <= (cs->base + cs->size)) {
> +		if (cs->base <= phyaddr && phyaddr <= (cs->base + cs->size - 1)) {

Wouldn't it be better to change the line to:
> +		if (cs->base <= phyaddr && phyaddr < (cs->base + cs->size)) {

	David

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 00/10] Proposal for a API set for HW Buffer management Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-01-12 20:20 +0100
  [PATCH net-next 02/10] ARM: mvebu: enable SRAM support in mvebu_v7_defconfig Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-01-12 20:20 +0100
  [PATCH net-next 05/10] ARM: mvebu: enable buffer manager support on Armada 38x boards Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-01-12 20:20 +0100
  [PATCH net-next 10/10] net: mvneta: Use the new hwbm framework Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-01-12 20:20 +0100
    Re: [PATCH net-next 10/10] net: mvneta: Use the new hwbm framework Marcin Wojtas <mw@semihalf.com> - 2016-01-12 23:50 +0100
      Re: [PATCH net-next 10/10] net: mvneta: Use the new hwbm framework Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-01-13 18:50 +0100
  [PATCH net-next 07/10] ARM: mvebu: enable buffer manager support on Armada XP boards Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-01-12 20:20 +0100
  [PATCH net-next 01/10] bus: mvebu-mbus: provide api for obtaining IO and DRAM window information Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-01-12 20:20 +0100
  [PATCH net-next 08/10] bus: mvenus-mbus: Fix size test for mvebu_mbus_get_dram_win_info Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-01-12 20:20 +0100
    Re: [PATCH net-next 08/10] bus: mvenus-mbus: Fix size test for mvebu_mbus_get_dram_win_info Marcin Wojtas <mw@semihalf.com> - 2016-01-12 22:50 +0100
    RE: [PATCH net-next 08/10] bus: mvenus-mbus: Fix size test for  mvebu_mbus_get_dram_win_info David Laight <David.Laight@ACULAB.COM> - 2016-01-14 15:10 +0100
  [PATCH net-next 06/10] ARM: mvebu: add buffer manager nodes to armada-xp.dtsi Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-01-12 20:20 +0100
  [PATCH net-next 09/10] net: Add a hardware buffer management helper API Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-01-12 20:20 +0100
  [PATCH net-next 04/10] ARM: mvebu: add buffer manager nodes to armada-38x.dtsi Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-01-12 20:20 +0100
  Re: [PATCH net-next 03/10] net: mvneta: bm: add support for hardware  buffer management Marcin Wojtas <mw@semihalf.com> - 2016-01-12 21:20 +0100
    Re: [PATCH net-next 03/10] net: mvneta: bm: add support for hardware buffer management Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-01-13 18:40 +0100
  Re: [PATCH net-next 00/10] Proposal for a API set for HW Buffer  management David Miller <davem@davemloft.net> - 2016-01-12 22:00 +0100
    Re: [PATCH net-next 00/10] Proposal for a API set for HW Buffer management Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-01-13 18:40 +0100
      Re: [PATCH net-next 00/10] Proposal for a API set for HW Buffer  management David Miller <davem@davemloft.net> - 2016-01-13 21:00 +0100

csiph-web