Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1309188

Re: [PATCH v2] reboot: Backup orderly_poweroff

From Ingo Molnar <mingo@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2] reboot: Backup orderly_poweroff
Date 2016-01-14 12:30 +0100
Message-ID <qQOgh-6eV-1@gated-at.bofh.it> (permalink)
References <qQsSv-89F-27@gated-at.bofh.it> <qQM4O-4UH-13@gated-at.bofh.it> <qQMoa-51q-9@gated-at.bofh.it> <qQN0S-5vL-15@gated-at.bofh.it> <qQNDz-5Lf-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

* Keerthy <a0393675@ti.com> wrote:

> I tried to simulate the issue.
> 
> In the probe function of drivers/thermal/ti-soc-thermal/ti-bandgap.c
> ti_bandgap_probe i call
> 
> orderly_poweroff(true);
> 
> This is while driver probes are still on going. I observe that
> ret = run_cmd(poweroff_cmd);
> 
> ret is a non-zero value and we enter the if condition:
> 
> Even after the
> 
> emergency_sync();
> kernel_power_off();
> 
> calls
> 
> the console remained active in weird state.

Now _that_ is clearly an architecture bug that should not be papered over ...

If kernel_power_off() is called then the system should power off. No ifs and 
whens.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] reboot: Backup orderly_poweroff  Keerthy <j-keerthy@ti.com> - 2016-01-13 13:40 +0100
  Re: [PATCH v2] reboot: Backup orderly_poweroff Ingo Molnar <mingo@kernel.org> - 2016-01-14 10:10 +0100
    Re: [PATCH v2] reboot: Backup orderly_poweroff Keerthy <a0393675@ti.com> - 2016-01-14 10:30 +0100
      Re: [PATCH v2] reboot: Backup orderly_poweroff Ingo Molnar <mingo@kernel.org> - 2016-01-14 11:10 +0100
        Re: [PATCH v2] reboot: Backup orderly_poweroff Keerthy <a0393675@ti.com> - 2016-01-14 11:50 +0100
          Re: [PATCH v2] reboot: Backup orderly_poweroff Ingo Molnar <mingo@kernel.org> - 2016-01-14 12:30 +0100
            Re: [PATCH v2] reboot: Backup orderly_poweroff One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-01-14 14:30 +0100
            Re: [PATCH v2] reboot: Backup orderly_poweroff Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-01-14 15:30 +0100

csiph-web