Re: [PATCH v6 12/15] tty: serial: 8250: Correct conversion specifiers

From	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 12/15] tty: serial: 8250: Correct conversion specifiers
Date	2016-01-14 10:40 +0100
Message-ID	<qQMxQ-54U-11@gated-at.bofh.it> (permalink)
References	<qQBj4-5yt-5@gated-at.bofh.it> <qQBj4-5yt-17@gated-at.bofh.it>
Organization	Intel Finland Oy

Show all headers | View raw

On Wed, 2016-01-13 at 22:29 +0100, Anton Wuerfel wrote:
> This patch fixes compiler warnings about wrong conversion specifiers 

This patch obviously doesn't _fix_warnings_, rather changes specifiers
to get it consistent with argument.

> used
> in a debug output in 8250_pnp.c. The precise warning is:

Usually there is no need to cite all lines…

> 
> drivers/tty/serial/8250/8250_pnp.c: In function ‘serial_pnp_probe’:
> include/linux/dynamic_debug.h:64:16: warning: format ‘%x’ expects
> argument
> of [...]

OK.

> 
> include/linux/dynamic_debug.h:84:2: note: in expansion of macro
> ‘DEFINE_DYNAMIC_DEBUG_METADATA’
> 
> include/linux/device.h:1179:2: note: in expansion of macro
> ‘dynamic_dev_dbg’

Redundant.

> 
> drivers/tty/serial/8250/8250_pnp.c:467:2: note: in expansion of macro
> ‘dev_dbg’
>   dev_dbg(&dev->dev,
>   ^
> include/linux/dynamic_debug.h:64:16: warning: format ‘%lx’ expects
> argument
> of [...]

OK.

> 
> include/linux/dynamic_debug.h:84:2: note: in expansion of macro
> ‘DEFINE_DYNAMIC_DEBUG_METADATA’
> 
> include/linux/device.h:1179:2: note: in expansion of macro
> ‘dynamic_dev_dbg’

Redundant.

> 
> drivers/tty/serial/8250/8250_pnp.c:467:2: note: in expansion of macro
> ‘dev_dbg’
>   dev_dbg(&dev->dev,
>   ^
> 
> Those warnings never got triggered, because the command was nested
> in an #ifdef, which is removed by a patch of this series.
> 
> Signed-off-by: Anton Würfel <anton.wuerfel@fau.de>
> Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de>
> Cc: linux-kernel@i4.cs.fau.de
> ---
>  drivers/tty/serial/8250/8250_pnp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_pnp.c
> b/drivers/tty/serial/8250/8250_pnp.c
> index 0c32c59..92f4412 100644
> --- a/drivers/tty/serial/8250/8250_pnp.c
> +++ b/drivers/tty/serial/8250/8250_pnp.c
> @@ -465,8 +465,8 @@ serial_pnp_probe(struct pnp_dev *dev, const
> struct pnp_device_id *dev_id)
>  		return -ENODEV;
>  
>  	dev_dbg(&dev->dev,
> -		 "Setup PNP port: port %x, mem 0x%lx, irq %d, type
> %d\n",
> -		 uart.port.iobase, uart.port.mapbase,
> +		 "Setup PNP port: port %lx, mem 0x%lx, irq %d, type
> %d\n",
> +		 uart.port.iobase, (unsigned long)uart.port.mapbase,

This approach is not fully correct. In Linux kernel we have %p
extensions to cover some custom types such as resource_size_t, of which
mapbase is.

Thus,

"Setup PNP port: port %lx, mem %pa, irq %d, type %d\n",
uart.port.iobase, &uart.port.mapbase,

looks better.

>  		 uart.port.irq, uart.port.iotype);
>  
>  	if (flags & CIR_PORT) {

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6 12/15] tty: serial: 8250: Correct conversion specifiers Anton Wuerfel <anton.wuerfel@fau.de> - 2016-01-13 22:40 +0100
  Re: [PATCH v6 12/15] tty: serial: 8250: Correct conversion  specifiers Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-14 10:40 +0100

csiph-web