Re: [PATCH 2/2] soc: versatile: Drop a useless static qualifier

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] soc: versatile: Drop a useless static qualifier
Date	2016-01-14 10:20 +0100
Message-ID	<qQMeu-4Y2-11@gated-at.bofh.it> (permalink)
References	<qPE9j-6Vv-9@gated-at.bofh.it> <qPE9k-6Vv-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jan 11, 2016 at 7:16 AM, Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:

> There is no need to have the 'struct regmap *syscon_regmap' variable
> static in the probe function.
> It only wastes a few bytes of memory.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Sorry a copy-paste error ... used to have it as a global.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

I think you should send this to arm@kernel.org for application
as a fixup to the ARM SoC tree. Include my Review tag.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] soc: versatile: Add missing kfree in error path Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-01-11 07:30 +0100
  [PATCH 2/2] soc: versatile: Drop a useless static qualifier Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-01-11 07:30 +0100
    Re: [PATCH 2/2] soc: versatile: Drop a useless static qualifier Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-12 12:50 +0100
    Re: [PATCH 2/2] soc: versatile: Drop a useless static qualifier Linus Walleij <linus.walleij@linaro.org> - 2016-01-14 10:20 +0100

csiph-web