Re: [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410
Date	2016-01-14 11:00 +0100
Message-ID	<qQMRc-5dh-3@gated-at.bofh.it> (permalink)
References	<qPO8F-5nr-9@gated-at.bofh.it> <qQM4O-4UH-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 01/14/2016 01:02 AM, Linus Walleij wrote:
> On Mon, Jan 11, 2016 at 6:00 PM, Guenter Roeck <linux@roeck-us.net> wrote:
>
>> Since commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct"),
>> all users of struct bgpio_pdata depend on GPIO_GENERIC.
>>
>> This results in the following build error.
>>
>> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
>>          excess elements in struct initializer
>> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
>>          (near initialization for '(anonymous)')
>> arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error:
>>          invalid use of undefined type 'struct bgpio_pdata'
>>
>> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> I don't know if this is the correct way to fix this problem.
>> If not, please consider this to be a bug report.
>
> I think this is fixed by Arnds patch:
> http://marc.info/?l=linux-gpio&m=145237423205247&w=2
>
> Can you verify that?
>

Correct.

Guenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410 Guenter Roeck <linux@roeck-us.net> - 2016-01-11 18:10 +0100
  Re: [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-12 02:00 +0100
    Re: [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410 Guenter Roeck <linux@roeck-us.net> - 2016-01-12 02:30 +0100
  Re: [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410 Linus Walleij <linus.walleij@linaro.org> - 2016-01-14 10:10 +0100
    Re: [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410 Guenter Roeck <linux@roeck-us.net> - 2016-01-14 11:00 +0100

csiph-web