Re: [PATCH] ssb: host_soc depends on sprom

From	Rafał Miłecki <zajec5@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ssb: host_soc depends on sprom
Date	2016-01-14 09:50 +0100
Message-ID	<qQLLs-4xW-7@gated-at.bofh.it> (permalink)
References	<qQCyu-6kn-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 13 January 2016 at 23:51, Arnd Bergmann <arnd@arndb.de> wrote:
> Drivers that use the SSB sprom functionality typically 'select SSB_SPROM'
> from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in
> a build failure unless at least one of the other drivers that selects
> it is enabled:
>
> drivers/built-in.o: In function `ssb_host_soc_get_invariants':
> (.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback'
>
> This adds the same select statement that is used elsewhere.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch")

I missed this dependency, thanks, patch looks OK.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ssb: host_soc depends on sprom Arnd Bergmann <arnd@arndb.de> - 2016-01-14 00:00 +0100
  Re: [PATCH] ssb: host_soc depends on sprom Kalle Valo <kvalo@codeaurora.org> - 2016-01-14 07:50 +0100
    Re: [PATCH] ssb: host_soc depends on sprom David Miller <davem@davemloft.net> - 2016-01-14 22:50 +0100
    [PATCH, RESEND] ssb: mark ssb_bus_register as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2016-01-15 00:20 +0100
  Re: [PATCH] ssb: host_soc depends on sprom Rafał Miłecki <zajec5@gmail.com> - 2016-01-14 09:50 +0100

csiph-web