Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1309075

Re: [PATCH] uapi: update install list after nvme.h rename

From Jiri Slaby <jslaby@suse.cz>
Newsgroups linux.kernel
Subject Re: [PATCH] uapi: update install list after nvme.h rename
Date 2016-01-14 09:40 +0100
Message-ID <qQLBM-4uu-9@gated-at.bofh.it> (permalink)
References <qPzjj-3EA-1@gated-at.bofh.it> <qQ2Ol-6OM-17@gated-at.bofh.it> <qQEJY-7Zf-19@gated-at.bofh.it> <qQLs6-4qd-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 01/14/2016, 09:26 AM, Jiri Slaby wrote:
> On 01/14/2016, 02:17 AM, Mike Frysinger wrote:
>> On 12 Jan 2016 09:45, Jiri Slaby wrote:
>>> On 01/11/2016, 02:14 AM, Mike Frysinger wrote:
>>>> Commit 9d99a8dda154 ("nvme: move hardware structures out of
>>>> the uapi version of nvme.h") renamed nvme.h to nvme_ioctl.h,
>>>> but the uapi list still refers to nvme.h.  People trying to
>>>> install the headers hit a failure as the header no longer
>>>> exists.
>>> 
>>> Wouldn't reverting the rename be nicer to userspace? So that
>>> the filename is preserved and anybody who #included nvme.h
>>> still can do so?
> 
>> i have no opinion on either route
> 
>> on a related note, shouldn't headers install be part of the 
>> automatic kernel checks that are run against repos on kernel.org
>> ? who runs that thing ?

^^^^^

You have Fengguang's 0-day build robot on your mind? (CCed)

> I have been thinking about at least 'test -f' for all 'headers-y' 
> during make all. What do you think, Michal?


- -- 
js
suse labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWl1y5AAoJEL0lsQQGtHBJz/YP/27RtFl7wjkyhwY935/2FQeM
XmZ0/WUz2vJdMT6MNC8+cwZ5Vfua7SgNbXh8wLkzDxBufc3vBe3eugfTmrn4kAsL
GglaCDCvI5tduWVwV2CPvr1fSc9Jazj89OQld7+VhqIbKFxY4WkhWV06tHKUEPXd
2vgtSwsY4ka0CLWgdAsJZfdhBIG7tBwrlgxaWGf/kcUCRz9cavNt8FWGXUGWHnDI
J8h6eGld8TJPzvYEdHQD/MlAf/7Kle0m5MhMy+uUHdFrDWPrwqMLTDburcHyh59v
QatkLXyn7yZ2NeqPdF8FHW7Mp+A5oP+exSme7TYmKZzMNmwdx8um+gjUcd2Aq6LB
n/IhZp5rZBaPU6/CgYKvwy+jGPfkDI1WITO3YQlCkc/SzdvhjufgAFZ7MGYVA3NZ
iKsSMIi33ncN7D7TNevkPlHylp8HSx91girRtp0sP7cO2INRCl98SSiL9bq+a1Vm
tc3t64QE1YJ7/gsQ1/sfjVZIQ5sFNzTn9I4KpDWPkSWaOTl3ikULwxhop1touTdq
BGq+kVB20/cmt7sUNc4dieM97mlMD55vT3QQ1qyuUsyAdrdWE4npxo5OE43YBORL
/a8KJVscITLq7OK/QwlPi0wbSFlfGOe3LtFS8CqVWRBhQ+3Udy4eL4m7d9cB0Ats
ChQQpLBSRpN3sjuypY8d
=8T96
-----END PGP SIGNATURE-----

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] uapi: update install list after nvme.h rename Mike Frysinger <vapier@gentoo.org> - 2016-01-11 02:20 +0100
  Re: [PATCH] uapi: update install list after nvme.h rename Jiri Slaby <jslaby@suse.cz> - 2016-01-12 09:50 +0100
    Re: [PATCH] uapi: update install list after nvme.h rename Mike Frysinger <vapier@gentoo.org> - 2016-01-14 02:20 +0100
      Re: [PATCH] uapi: update install list after nvme.h rename Jiri Slaby <jslaby@suse.cz> - 2016-01-14 09:30 +0100
        Re: [PATCH] uapi: update install list after nvme.h rename Jiri Slaby <jslaby@suse.cz> - 2016-01-14 09:40 +0100
  Re: [PATCH] uapi: update install list after nvme.h rename Christoph Hellwig <hch@lst.de> - 2016-01-12 16:20 +0100

csiph-web