Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1307511

Re: [PATCH] kbuild: Demote 'sign-compare' warning to W=2

From Michal Marek <mmarek@suse.com>
Newsgroups linux.kernel
Subject Re: [PATCH] kbuild: Demote 'sign-compare' warning to W=2
Date 2016-01-12 16:10 +0100
Message-ID <qQ8K6-2Id-7@gated-at.bofh.it> (permalink)
References <qQ87p-28L-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 2016-01-12 15:24, Lee Jones wrote:
> Ideally, a kernel compile with W=1 enabled should complete cleanly;
> however, when we run one currently we are presented with ~25k warnings.
> 'sign-compare' accounts for ~22k of those ~25k.
> 
> In this patch we're demoting 'sign-compare' warnings to W=2, with a view
> to fixing the remaining 3k W=1 warnings required for a clean build.
> 
> Arnd adds:
>   "As per our discussion, I'd add that this was inadvertedly introduced
>    by Behan when he moved the clang specific warnings into an ifdef block
>    and did not notice that -Wsign-compare was interpreted by both gcc
>    and clang.
> 
>    Earlier, it was introduced in just the same way by Jan-Simon as part
>    of 3d3d6b847420 ("kbuild: LLVMLinux: Adapt warnings for compilation
>    with clang")."
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 26ea6bb1fef0 ("kbuild, LLVMLinux: Supress warnings unless W=1-3")
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Applied to kbuild.git#kbuild.

Michal

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] kbuild: Demote 'sign-compare' warning to W=2 Lee Jones <lee.jones@linaro.org> - 2016-01-12 15:30 +0100
  Re: [PATCH] kbuild: Demote 'sign-compare' warning to W=2 Michal Marek <mmarek@suse.com> - 2016-01-12 16:10 +0100

csiph-web