Re: [PATCH v2 6/7] udf: Remove struct ustr as non-needed intermediate storage

From	Jan Kara <jack@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 6/7] udf: Remove struct ustr as non-needed intermediate storage
Date	2016-01-12 14:40 +0100
Message-ID	<qQ7l1-1vx-41@gated-at.bofh.it> (permalink)
References	<qJgW5-Ay-7@gated-at.bofh.it> <qJgW5-Ay-9@gated-at.bofh.it> <qNcAy-3to-25@gated-at.bofh.it> <qPKRu-30B-47@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

  Hi Andrew,

On Mon 11-01-16 16:31:40, Andrew Gabbasov wrote:
> > >  
> > > -	ocu[length - 1] = (uint8_t)u_len + 1;
> > > -	return u_len + 1;
> > > +	return u_len;
> >
> > It seems you removed setting of the length in the resulting CS0 string.
> 
> Yes, and it was done deliberately.
> udf_name_to_CS0 and its caller udf_put_filename functions are used for
> writing File Identifier fields only, which are not "dstrings", that is
> not containing the length in last byte. The last byte with the length
> from these functions would not be copied to filesystem or used in any
> other way.

I see, you are right. OK.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 6/7] udf: Remove struct ustr as non-needed  intermediate storage Jan Kara <jack@suse.cz> - 2016-01-04 13:40 +0100
  RE: [PATCH v2 6/7] udf: Remove struct ustr as non-needed intermediate storage Andrew Gabbasov <andrew_gabbasov@mentor.com> - 2016-01-11 14:40 +0100
    Re: [PATCH v2 6/7] udf: Remove struct ustr as non-needed  intermediate storage Jan Kara <jack@suse.cz> - 2016-01-12 14:40 +0100

csiph-web