Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1307195
| Path | csiph.com!au2pb.net!2.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Viresh Kumar <viresh.kumar@linaro.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH 07/19] cpufreq: assert locking when accessing cpufreq_governor_list |
| Date | Tue, 12 Jan 2016 11:10:02 +0100 |
| Message-ID | <qQ43M-7TO-41@gated-at.bofh.it> (permalink) |
| References | <qPOBH-5zs-9@gated-at.bofh.it> <qPOLp-5E8-19@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=TvWROMV0TSH5j8mbZ+YI91xs48Wed8OH7RPPzjZO9es=; b=NkSnR0HI2vSpmRnPUvx56J47e68Al7ULDpsnXJbaN0OzFyppIVaM1j6bjSFVB8sb0x 79hduf8rYbQmyfhDmeLSQPvt17kbjWpAnEgMQHwvZlFXSNfEEYgFTQJts4+FrsYYvxn7 OoCvZxKF/n+DI5eVcvo2KZOPMGj6Y049fNgEs= |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=TvWROMV0TSH5j8mbZ+YI91xs48Wed8OH7RPPzjZO9es=; b=Iye5eRO2cJLecgV9PhS0IhUzWL0mLwt1jpAOj8cYWpekQ06UB1MXUF/Dw6L7egSYxL iTFMu3vxKPADum3REIeiaE9VN2Oa+g8lZYN7ABLeqsndsuru2LM4Ep+OorGNwWQsJPRy G5FX0td71Ewx1Mrt7TwvEZanvbfP6VZ+Ioey9T3zE9rnbJoLhDu49JSlVAW7UcSKYreE QspFKfUs6i7SYJXax09NYuO9z+4fEijO80lQ3hXB5GJab1V/AeL2g9ikVBvwzmnWfIQf vyw3Jgqu8un76X5RFbntgKBQ1FEA8BFC+pfD1stJKOo/9FAr52fdQGRbLxG7yzXpI4Gt zCdQ== |
| X-Gm-Message-State | ALoCoQkk0+Mc2Nff0dUYzXseky3DwtoSW9K+5eO3+SdBDmdLqLPHMx1vHtsRv1/1mRUy/d+vaKDv4s0hOnB1qP9mQc/bSaj9Vw== |
| X-Received | by 10.98.86.67 with SMTP id k64mr33494921pfb.50.1452592886361; Tue, 12 Jan 2016 02:01:26 -0800 (PST) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.21 (2010-09-15) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 37 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, peterz@infradead.org, rjw@rjwysocki.net, mturquette@baylibre.com, steve.muckle@linaro.org, vincent.guittot@linaro.org, morten.rasmussen@arm.com, dietmar.eggemann@arm.com |
| X-Original-Date | Tue, 12 Jan 2016 15:31:22 +0530 |
| X-Original-Message-ID | <20160112100122.GY1084@ubuntu> |
| X-Original-References | <1452533760-13787-1-git-send-email-juri.lelli@arm.com> <1452533760-13787-8-git-send-email-juri.lelli@arm.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1307195 |
Show key headers only | View raw
On 11-01-16, 17:35, Juri Lelli wrote:
> @@ -2025,6 +2027,7 @@ int cpufreq_register_governor(struct cpufreq_governor *governor)
> err = -EBUSY;
> if (!find_governor(governor->name)) {
> err = 0;
> + lockdep_assert_held(&cpufreq_governor_mutex);
> list_add(&governor->governor_list, &cpufreq_governor_list);
> }
Why here? This is how the routine looks like:
int cpufreq_register_governor(struct cpufreq_governor *governor)
{
int err;
if (!governor)
return -EINVAL;
if (cpufreq_disabled())
return -ENODEV;
mutex_lock(&cpufreq_governor_mutex);
governor->initialized = 0;
err = -EBUSY;
if (!find_governor(governor->name)) {
err = 0;
list_add(&governor->governor_list, &cpufreq_governor_list);
}
mutex_unlock(&cpufreq_governor_mutex);
return err;
}
--
viresh
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH 07/19] cpufreq: assert locking when accessing cpufreq_governor_list Juri Lelli <juri.lelli@arm.com> - 2016-01-11 18:50 +0100
Re: [RFC PATCH 07/19] cpufreq: assert locking when accessing cpufreq_governor_list Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-12 11:10 +0100
Re: [RFC PATCH 07/19] cpufreq: assert locking when accessing cpufreq_governor_list Juri Lelli <juri.lelli@arm.com> - 2016-01-12 16:40 +0100
csiph-web