[patch 1/2 -next] mdio: remove an unneed condition

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	[patch 1/2 -next] mdio: remove an unneed condition
Date	2016-01-12 10:40 +0100
Message-ID	<qQ3AL-7rn-37@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

It used to be that mdio->irq was a pointer but after e7f4dc3536a4
('mdio: Move allocation of interrupts into core') it's an array inside
the mdio struct so it can never be NULL.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
index c0a8f84..86829f8 100644
--- a/drivers/of/of_mdio.c
+++ b/drivers/of/of_mdio.c
@@ -62,11 +62,9 @@ static int of_mdiobus_register_phy(struct mii_bus *mdio, struct device_node *chi
 	rc = irq_of_parse_and_map(child, 0);
 	if (rc > 0) {
 		phy->irq = rc;
-		if (mdio->irq)
-			mdio->irq[addr] = rc;
+		mdio->irq[addr] = rc;
 	} else {
-		if (mdio->irq)
-			phy->irq = mdio->irq[addr];
+		phy->irq = mdio->irq[addr];
 	}
 
 	if (of_property_read_bool(child, "broken-turn-around"))

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[patch 1/2 -next] mdio: remove an unneed condition Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-12 10:40 +0100
  Re: [patch 1/2 -next] mdio: remove an unneed condition Andrew Lunn <andrew@lunn.ch> - 2016-01-12 15:10 +0100
  Re: [patch 1/2 -next] mdio: remove an unneed condition David Miller <davem@davemloft.net> - 2016-01-12 20:40 +0100

csiph-web