Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1307151

Re: [RFC PATCH 04/19] cpufreq: bring data structures close to their locks

From Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups linux.kernel
Subject Re: [RFC PATCH 04/19] cpufreq: bring data structures close to their locks
Date 2016-01-12 10:40 +0100
Message-ID <qQ3AJ-7rn-5@gated-at.bofh.it> (permalink)
References <qPOBH-5zs-9@gated-at.bofh.it> <qPOLn-5E8-1@gated-at.bofh.it> <qPSP1-7w-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 11-01-16, 23:07, Peter Zijlstra wrote:
> On Mon, Jan 11, 2016 at 05:35:45PM +0000, Juri Lelli wrote:
> > +/**
> > + * Iterate over governors
> > + *
> > + * cpufreq_governor_list is protected by cpufreq_governor_mutex.
> > + */
> > +static LIST_HEAD(cpufreq_governor_list);
> > +static DEFINE_MUTEX(cpufreq_governor_mutex);
> > +#define for_each_governor(__governor)				\
> > +	list_for_each_entry(__governor, &cpufreq_governor_list, governor_list)
> 
> So you could stuff the lockdep_assert_held() you later add intididually
> into the for_each_governor macro, impossible to forget that way.

How exactly? I couldn't see how it can be done in a neat and clean
way.

-- 
viresh

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC PATCH 04/19] cpufreq: bring data structures close to their locks Juri Lelli <juri.lelli@arm.com> - 2016-01-11 18:50 +0100
  Re: [RFC PATCH 04/19] cpufreq: bring data structures close to their  locks Peter Zijlstra <peterz@infradead.org> - 2016-01-11 23:10 +0100
    Re: [RFC PATCH 04/19] cpufreq: bring data structures close to their locks "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-01-12 00:10 +0100
      Re: [RFC PATCH 04/19] cpufreq: bring data structures close to their  locks Peter Zijlstra <peterz@infradead.org> - 2016-01-12 09:30 +0100
        Re: [RFC PATCH 04/19] cpufreq: bring data structures close to their  locks Juri Lelli <juri.lelli@arm.com> - 2016-01-12 11:50 +0100
        Re: [RFC PATCH 04/19] cpufreq: bring data structures close to their locks "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-01-12 17:50 +0100
  Re: [RFC PATCH 04/19] cpufreq: bring data structures close to their  locks Peter Zijlstra <peterz@infradead.org> - 2016-01-11 23:10 +0100
    Re: [RFC PATCH 04/19] cpufreq: bring data structures close to their  locks Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-12 10:40 +0100
      Re: [RFC PATCH 04/19] cpufreq: bring data structures close to their  locks Juri Lelli <juri.lelli@arm.com> - 2016-01-12 12:30 +0100
        Re: [RFC PATCH 04/19] cpufreq: bring data structures close to their  locks Peter Zijlstra <peterz@infradead.org> - 2016-01-12 13:00 +0100
          Re: [RFC PATCH 04/19] cpufreq: bring data structures close to their  locks Juri Lelli <juri.lelli@arm.com> - 2016-01-12 13:40 +0100
            Re: [RFC PATCH 04/19] cpufreq: bring data structures close to their  locks Juri Lelli <juri.lelli@arm.com> - 2016-01-12 16:30 +0100
              Re: [RFC PATCH 04/19] cpufreq: bring data structures close to their  locks Peter Zijlstra <peterz@infradead.org> - 2016-01-12 17:00 +0100

csiph-web