Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1305746
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Andrew Lunn <andrew@lunn.ch> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH -next] net: ethernet: broadcom: Fix build errors |
| Date | Mon, 11 Jan 2016 01:00:03 +0100 |
| Message-ID | <qPy3V-2Gd-3@gated-at.bofh.it> (permalink) |
| References | <qPutk-s4-3@gated-at.bofh.it> |
| X-Original-To | Guenter Roeck <linux@roeck-us.net> |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.21 (2010-09-15) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 62 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Mon, 11 Jan 2016 00:53:09 +0100 |
| X-Original-Message-ID | <20160110235309.GA25548@lunn.ch> |
| X-Original-References | <1452456196-1624-1-git-send-email-linux@roeck-us.net> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1305746 |
Show key headers only | View raw
On Sun, Jan 10, 2016 at 12:03:16PM -0800, Guenter Roeck wrote:
> Commit 7f854420fbfe ("phy: Add API for {un}registering an mdio device to
> a bus") introduces an API to access mii_bus structures, but missed to
> update the sb1250 driver. This results in the following build error.
>
> drivers/net/ethernet/broadcom/sb1250-mac.c: In function 'sbmac_mii_probe':
> drivers/net/ethernet/broadcom/sb1250-mac.c:2360:24: error:
> 'struct mii_bus' has no member named 'phy_map'
>
> Use phy_find_first() instead of open coding it.
>
> Commit 2220943a21e2 ("phy: Centralise print about attached phy") introduces
> the following build error.
>
> drivers/net/ethernet/broadcom/sb1250-mac.c: In function 'sbmac_mii_probe':
> drivers/net/ethernet/broadcom/sb1250-mac.c:2383:20: error: 'phydev' undeclared
>
> Fixes: 7f854420fbfe ("phy: Add API for {un}registering an mdio device to a bus")
> Fixes: 2220943a21e2 ("phy: Centralise print about attached phy")
> Cc: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Andrew Lunn <andrew@lunn.ch>
Thanks
Andrew
> ---
> drivers/net/ethernet/broadcom/sb1250-mac.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/sb1250-mac.c b/drivers/net/ethernet/broadcom/sb1250-mac.c
> index 768c18da510c..eacc559679bf 100644
> --- a/drivers/net/ethernet/broadcom/sb1250-mac.c
> +++ b/drivers/net/ethernet/broadcom/sb1250-mac.c
> @@ -2354,13 +2354,8 @@ static int sbmac_mii_probe(struct net_device *dev)
> {
> struct sbmac_softc *sc = netdev_priv(dev);
> struct phy_device *phy_dev;
> - int i;
>
> - for (i = 0; i < PHY_MAX_ADDR; i++) {
> - phy_dev = sc->mii_bus->phy_map[i];
> - if (phy_dev)
> - break;
> - }
> + phy_dev = phy_find_first(sc->mii_bus);
> if (!phy_dev) {
> printk(KERN_ERR "%s: no PHY found\n", dev->name);
> return -ENXIO;
> @@ -2385,7 +2380,7 @@ static int sbmac_mii_probe(struct net_device *dev)
> SUPPORTED_Pause |
> SUPPORTED_Asym_Pause;
>
> - phy_attached_info(phydev);
> + phy_attached_info(phy_dev);
>
> phy_dev->advertising = phy_dev->supported;
>
> --
> 2.1.4
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH -next] net: ethernet: broadcom: Fix build errors Guenter Roeck <linux@roeck-us.net> - 2016-01-10 21:10 +0100 Re: [PATCH -next] net: ethernet: broadcom: Fix build errors Andrew Lunn <andrew@lunn.ch> - 2016-01-11 01:00 +0100 Re: [PATCH -next] net: ethernet: broadcom: Fix build errors David Miller <davem@davemloft.net> - 2016-01-11 04:10 +0100
csiph-web