Re: [PATCH 2/2] virtio_balloon: fix race between migration and ballooning

Path	csiph.com!au2pb.net!weretis.net!feeder6.news.weretis.net!news.glorb.com!bofh.it!news.nic.it!robomod
From	Minchan Kim <minchan@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] virtio_balloon: fix race between migration and ballooning
Date	Mon, 11 Jan 2016 01:00:03 +0100
Message-ID	<qPy3V-2Gd-13@gated-at.bofh.it> (permalink)
References	<qKw2J-3Io-13@gated-at.bofh.it> <qKw2M-3Io-97@gated-at.bofh.it> <qM4lH-ob-7@gated-at.bofh.it> <qN1c6-4fx-9@gated-at.bofh.it> <qPw26-1mc-7@gated-at.bofh.it>
X-Original-Senderip	156.147.1.126
X-Original-Mailfrom	minchan@kernel.org
X-Original-Senderip	165.244.98.150
X-Original-Mailfrom	minchan@kernel.org
X-Original-Senderip	10.177.223.161
X-Original-Mailfrom	minchan@kernel.org
MIME-Version	1.0
User-Agent	Mutt/1.5.21 (2010-09-15)
X-Mimetrack	Itemize by SMTP Server on LGEKRMHUB05/LGE/LG Group(Release 8.5.3FP6\|November 21, 2013) at 2016/01/11 08:52:11, Serialize by Router on LGEKRMHUB05/LGE/LG Group(Release 8.5.3FP6\|November 21, 2013) at 2016/01/11 08:52:11, Serialize complete at 2016/01/11 08:52:11
Content-Type	text/plain; charset="us-ascii"
Content-Disposition	inline
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	15
Organization	linux.* mail to news gateway
X-Original-Cc	Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Konstantin Khlebnikov <koct9i@gmail.com>, Rafael Aquini <aquini@redhat.com>, stable@vger.kernel.org
X-Original-Date	Mon, 11 Jan 2016 08:54:09 +0900
X-Original-Message-ID	<20160110235409.GA7452@bbox>
X-Original-References	<1451259313-26353-1-git-send-email-minchan@kernel.org> <1451259313-26353-2-git-send-email-minchan@kernel.org> <20160101102756-mutt-send-email-mst@redhat.com> <20160104002747.GA31090@blaptop.local> <20160110233310-mutt-send-email-mst@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1305748

Show key headers only | View raw

On Sun, Jan 10, 2016 at 11:40:17PM +0200, Michael S. Tsirkin wrote:
> On Mon, Jan 04, 2016 at 09:27:47AM +0900, Minchan Kim wrote:
> > > I think this will cause deadlocks.
> > > 
> > > pages_lock now nests within page lock, balloon_page_putback
> > > nests them in the reverse order.
> > 
> > In balloon_page_dequeu, we used trylock so I don't think it's
> > deadlock.
> 
> I went over this again and I don't see the issue anymore.
> I think I was mistaken, so I dropped my patch and picked
> up yours. Sorry about the noise.

No problem. Thanks for the review.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] virtio_balloon: fix race between migration and  ballooning Minchan Kim <minchan@kernel.org> - 2016-01-04 01:30 +0100
  Re: [PATCH 2/2] virtio_balloon: fix race between migration and  ballooning "Michael S. Tsirkin" <mst@redhat.com> - 2016-01-10 22:50 +0100
    Re: [PATCH 2/2] virtio_balloon: fix race between migration and  ballooning Minchan Kim <minchan@kernel.org> - 2016-01-11 01:00 +0100

csiph-web