Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1305704
| From | Timur Tabi <timur@tabi.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults |
| Date | 2016-01-10 22:40 +0100 |
| Message-ID | <qPvSq-1hU-17@gated-at.bofh.it> (permalink) |
| References | <qHSVP-5qX-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Maciej S. Szmigiero wrote:
> There is no guarantee that on fsl_ssi module load
> SSI registers will have their power-on-reset values.
>
> In fact, if the driver is reloaded the values in
> registers will be whatever they were set to previously.
>
> This fixes hard lockup on fsl_ssi module reload,
> at least in AC'97 mode.
>
> Fixes: 05cf237972fe ("ASoC: fsl_ssi: Add driver suspend and resume to support MEGA Fast")
>
> Signed-off-by: Maciej S. Szmigiero<mail@maciej.szmigiero.name>
Acked-by: Timur Tabi <timur@tabi.org>
I'm surprised that we're actually encouraging drivers to contain
hard-coded register values.
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults Timur Tabi <timur@tabi.org> - 2016-01-10 22:40 +0100
csiph-web