Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1305637

Re: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe function

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe function
Date 2016-01-10 18:30 +0100
Message-ID <qPrYu-7ci-19@gated-at.bofh.it> (permalink)
References (2 earlier) <qP6hk-NV-3@gated-at.bofh.it> <qP8Ma-2pZ-5@gated-at.bofh.it> <qPpWH-5U9-25@gated-at.bofh.it> <qPqzo-6aA-23@gated-at.bofh.it> <qPr2q-6AY-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> drivers/net/ethernet/amd/au1000_eth.c:  /* WARNING: bus->phy_map[phy_addr].attached_dev == dev does
> 	[ no idea what to do with that comment ]

That comment is very generic, it applies to all MDIO devices. So i'm
tempted to remove it. I will send a patch, probably tomorrow.

> drivers/net/ethernet/broadcom/sb1250-mac.c:             phy_dev = sc->mii_bus->phy_map[i];
> 	[ can use phy_find_first ]

Yes, phy_find_first.

> drivers/staging/netlogic/xlr_net.c:     struct phy_device *phydev = priv->mii_bus->phy_map[priv->phy_addr];
> 	[ several ]	

Odd that i missed that file for phy_map, but did patch it for
phydev_name().

I will send a patch for that, but probably tomorrow.

  Andrew

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH -next 1/2] net: bfin_mac: Fix error handling in probe function Guenter Roeck <linux@roeck-us.net> - 2016-01-09 17:40 +0100
  [PATCH -next 2/2] net: bfin_mac: Fix build error due to missed API change Guenter Roeck <linux@roeck-us.net> - 2016-01-09 17:40 +0100
  Re: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe  function Andrew Lunn <andrew@lunn.ch> - 2016-01-09 18:00 +0100
    Re: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe  function Guenter Roeck <linux@roeck-us.net> - 2016-01-09 19:20 +0100
      Re: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe  function Andrew Lunn <andrew@lunn.ch> - 2016-01-09 22:00 +0100
        Re: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe  function Guenter Roeck <linux@roeck-us.net> - 2016-01-10 16:20 +0100
          Re: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe  function Andrew Lunn <andrew@lunn.ch> - 2016-01-10 17:00 +0100
            Re: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe  function Guenter Roeck <linux@roeck-us.net> - 2016-01-10 17:30 +0100
              Re: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe  function Andrew Lunn <andrew@lunn.ch> - 2016-01-10 18:30 +0100
                Re: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe  function Guenter Roeck <linux@roeck-us.net> - 2016-01-10 21:20 +0100
                Re: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe  function Andrew Lunn <andrew@lunn.ch> - 2016-01-11 01:00 +0100
          Re: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe  function Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-11 09:50 +0100
            Re: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe  function Guenter Roeck <linux@roeck-us.net> - 2016-01-11 17:30 +0100

csiph-web