Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1305625

Re: [PATCH -next v2] net: bfin_mac: Fix build error due to missed API change

Show all headers | View raw

On Sun, Jan 10, 2016 at 07:08:04AM -0800, Guenter Roeck wrote:
> Commit 7f854420fbfe ("phy: Add API for {un}registering an mdio device to
> a bus") introduces an API to access mii_bus structures, but missed to
> update the bfin_mac driver. This results in the following error message
> 
> drivers/net/ethernet/adi/bfin_mac.c: In function 'mii_probe':
> drivers/net/ethernet/adi/bfin_mac.c:401:52: error:
> 	'struct mii_bus' has no member named 'phy_map'
> 
> Use phy_find_first() instead of open-coding it.
> 
> Fixes: 7f854420fbfe ("phy: Add API for {un}registering an mdio device to a bus")
> Cc: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Acked-by: Andrew Lunn <andrew@lunn.ch>

Hi Dave

Although Sadip Mukerjee's patch [PATCH 1/2] phy: fix blackfin build failure
is correct, this one is better. Please take this one in preference. 
We do still however need Sadip's [2/2] bfin_mac: fix error path

   Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -next v2] net: bfin_mac: Fix build error due to missed API change Guenter Roeck <linux@roeck-us.net> - 2016-01-10 16:10 +0100
  Re: [PATCH -next v2] net: bfin_mac: Fix build error due to missed  API change Andrew Lunn <andrew@lunn.ch> - 2016-01-10 16:50 +0100
    Re: [PATCH -next v2] net: bfin_mac: Fix build error due to missed  API change David Miller <davem@davemloft.net> - 2016-01-11 05:40 +0100

csiph-web