[PATCH -next] efi: Do not include asm/efi.h if not needed

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	[PATCH -next] efi: Do not include asm/efi.h if not needed
Date	2016-01-10 16:40 +0100
Message-ID	<qPqg2-62t-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Commit f7d924894265 ("arm64/efi: refactor EFI init and runtime code
for reuse by 32-bit ARM") adds an include of asm/efi.h to efi.c.
This causes a build failure for ia64, where asm/efi.h does not exist.

drivers/firmware/efi/efi.c:28:21: fatal error:
	asm/efi.h: No such file or directory

asm/efi.h does not define or declare anything used by efi.c, thus
including it should not be needed.

Fixes: f7d924894265 ("arm64/efi: refactor EFI init and runtime code for reuse by 32-bit ARM")
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Will Deacon <will.deacon@arm.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/firmware/efi/efi.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index cffa89b3317b..027ca212179f 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -25,8 +25,6 @@
 #include <linux/io.h>
 #include <linux/platform_device.h>
 
-#include <asm/efi.h>
-
 struct efi __read_mostly efi = {
 	.mps			= EFI_INVALID_TABLE_ADDR,
 	.acpi			= EFI_INVALID_TABLE_ADDR,
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] efi: Do not include asm/efi.h if not needed Guenter Roeck <linux@roeck-us.net> - 2016-01-10 16:40 +0100
  Re: [PATCH -next] efi: Do not include asm/efi.h if not needed Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-01-10 18:10 +0100
    Re: [PATCH -next] efi: Do not include asm/efi.h if not needed Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-01-10 18:40 +0100
      Re: [PATCH -next] efi: Do not include asm/efi.h if not needed Guenter Roeck <linux@roeck-us.net> - 2016-01-10 20:50 +0100
        Re: [PATCH -next] efi: Do not include asm/efi.h if not needed Guenter Roeck <linux@roeck-us.net> - 2016-01-10 20:50 +0100

csiph-web