Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1305617
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/3] checkpatch.pl: add missing memory barriers |
| Date | 2016-01-10 16:20 +0100 |
| Message-ID | <qPpWG-5U9-7@gated-at.bofh.it> (permalink) |
| References | <qPmP8-3H8-7@gated-at.bofh.it> <qPmP8-3H8-9@gated-at.bofh.it> <qPpN0-5Qp-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sun, 2016-01-10 at 07:07 -0800, Joe Perches wrote:
> On Sun, 2016-01-10 at 13:56 +0200, Michael S. Tsirkin wrote:
> > SMP-only barriers were missing in checkpatch.pl
> >
> > Refactor code slightly to make adding more variants easier.
> []
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> If I use a variable called $smp_barriers, I'd expect
> it to actually be the smp_barriers, not to have to
> prefix it with smp_ before using it.
>
> my $smp_barriers = qr{
> smp_store_release|
> smp_load_acquire|
> smp_store_mb|
> smp_read_barrier_depends
That's missing (?:barriers) too.
btw: shouldn't this also have
smp_mb__(?:before|after)_atomic
?
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 1/3] checkpatch.pl: add missing memory barriers "Michael S. Tsirkin" <mst@redhat.com> - 2016-01-10 13:00 +0100
Re: [PATCH v2 1/3] checkpatch.pl: add missing memory barriers Joe Perches <joe@perches.com> - 2016-01-10 16:10 +0100
Re: [PATCH v2 1/3] checkpatch.pl: add missing memory barriers Joe Perches <joe@perches.com> - 2016-01-10 16:20 +0100
Re: [PATCH v2 1/3] checkpatch.pl: add missing memory barriers "Michael S. Tsirkin" <mst@redhat.com> - 2016-01-10 20:30 +0100
Re: [PATCH v2 1/3] checkpatch.pl: add missing memory barriers "Michael S. Tsirkin" <mst@redhat.com> - 2016-01-10 20:20 +0100
csiph-web