Re: [PATCH] irq: action setting before irq_startup

Path	csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod
From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] irq: action setting before irq_startup
Date	Sun, 10 Jan 2016 11:20:02 +0100
Message-ID	<qPlgm-2Ne-7@gated-at.bofh.it> (permalink)
References	<qP0lA-54s-13@gated-at.bofh.it>
User-Agent	Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version	1.0
Content-Type	TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score	-1.0
X-Linutronix-Spam-Level	-
X-Linutronix-Spam-Status	No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	34
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org
X-Original-Date	Sun, 10 Jan 2016 11:13:35 +0100 (CET)
X-Original-Message-ID	<alpine.DEB.2.11.1601101112230.3575@nanos>
X-Original-References	<1452340701-20697-1-git-send-email-ysato@users.sourceforge.jp>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1305529

Show key headers only | View raw

On Sat, 9 Jan 2016, Yoshinori Sato wrote:

> In non shared and non threaded IRQ case.
> irq_startup calling before desc->action initialize.

And how does that matter? 
 
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> ---
>  kernel/irq/manage.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index 0eebaee..f6cdb63 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -1272,6 +1272,8 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
>  		goto out_mask;
>  	}
>  
> +	*old_ptr = new;
> +
>  	if (!shared) {
>  		ret = irq_request_resources(desc);
>  		if (ret) {

So in case irq_request_resources() fails, you leak the action in the irq
descriptor.

Again, what's the problem you are trying to solve?

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] irq: action setting before irq_startup Yoshinori Sato <ysato@users.sourceforge.jp> - 2016-01-09 13:00 +0100
  Re: [PATCH] irq: action setting before irq_startup Thomas Gleixner <tglx@linutronix.de> - 2016-01-10 11:20 +0100

csiph-web