Re: [PATCH] m68k: fix build failure

From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] m68k: fix build failure
Date	2016-01-10 11:00 +0100
Message-ID	<qPkX0-2qS-1@gated-at.bofh.it> (permalink)
References	<qNb1N-2kn-25@gated-at.bofh.it> <qPkDE-2iG-11@gated-at.bofh.it> <qPkDE-2iG-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Jan 10, 2016 at 10:37 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Sun, Jan 10, 2016 at 10:35 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> On Mon, Jan 4, 2016 at 11:57 AM, Sudip Mukherjee
>> <sudipm.mukherjee@gmail.com> wrote:
>>> The defconfig build of m68k was failing with the error:
>>> implicit declaration of function '__pfn_to_phys'
>>>
>>> Other architectures have added <asm/memory.h>, but if we do so here then
>>> we will also get redeclaration of some other functions. So it is better
>>> to copy these macros into page_mm.h.
>>>
>>> Fixes: 0a3c3bf11240 ("x86, mm: introduce vmem_altmap to augment vmemmap_populate()")
>>> Cc: Dan Williams <dan.j.williams@intel.com>
>>> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
>>
>> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Or should I take this through the m68k tree? It's getting a bit late for
> adding new v4.5 stuff...
>
> I see it's already in mm.

I would like to withdraw my Acked-by.

I'm gonna apply it to page.h instead of page_mm.h, to cover the nommu
case, and will queue for v4.5.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Thread

[PATCH] m68k: fix build failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-04 12:00 +0100
  Re: [PATCH] m68k: fix build failure Geert Uytterhoeven <geert@linux-m68k.org> - 2016-01-10 10:40 +0100
    Re: [PATCH] m68k: fix build failure Geert Uytterhoeven <geert@linux-m68k.org> - 2016-01-10 11:00 +0100
  Re: [PATCH] m68k: fix build failure Geert Uytterhoeven <geert@linux-m68k.org> - 2016-01-10 10:40 +0100

csiph-web