Re: [PATCH -next 1/2] net: tc35815: Fix build error due to missed API change

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH -next 1/2] net: tc35815: Fix build error due to missed API change
Date	2016-01-10 03:50 +0100
Message-ID	<qPeeR-6dV-1@gated-at.bofh.it> (permalink)
References	<qP9fc-2RT-11@gated-at.bofh.it> <qP9oS-2Xj-7@gated-at.bofh.it> <qP9Ie-35p-7@gated-at.bofh.it> <qP9RU-3o9-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 01/09/2016 02:09 PM, Andrew Lunn wrote:
>>> Hi Guenter
>>>
>>> You fix looks right, but i'm wondering about the code which is being
>>> fixed.
>>>
>>> How can phydev ever evaluate to true, given the break statement?  Can
>>> this code every detect multiple PHYs? I think not.
>>>
>>> Either the break needs to be removed, or we just replace the whole lot
>>> with phy_find_first().
>>>
>>
>> Hi Andrew,
>>
>> you are right, the current code is pretty pointless.
>>
>> I would suggest to use phy_find_first().
>
> Me too.
>
>> Should I submit a separate patch, or replace my patch with v2 ?
>
> I say a v2 which uses phy_find_first() and include in the changelog
> why the current code is pointless and so the change to
> phy_find_first().
>

Ok, I'll do that.

Guenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH -next 1/2] net: tc35815: Fix build error due to missed API change Guenter Roeck <linux@roeck-us.net> - 2016-01-09 22:30 +0100
  Re: [PATCH -next 1/2] net: tc35815: Fix build error due to missed  API change Andrew Lunn <andrew@lunn.ch> - 2016-01-09 22:40 +0100
    Re: [PATCH -next 1/2] net: tc35815: Fix build error due to missed API  change Guenter Roeck <linux@roeck-us.net> - 2016-01-09 23:00 +0100
      Re: [PATCH -next 1/2] net: tc35815: Fix build error due to missed  API change Andrew Lunn <andrew@lunn.ch> - 2016-01-09 23:10 +0100
        Re: [PATCH -next 1/2] net: tc35815: Fix build error due to missed API  change Guenter Roeck <linux@roeck-us.net> - 2016-01-10 03:50 +0100

csiph-web