Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1306875

Re: [PATCH] net: preserve IP control block during GSO segmentation

Show all headers | View raw

On Sun, Jan 10, 2016 at 11:45 PM, Zang MingJie <zealot0630@gmail.com> wrote:
> On 01/08/2016 08:13 PM, David Laight wrote:
>>
>> You could set SKB_SGO_CB_OFFSET to sizeof ((skb)->cb) - sizeof (struct
>> skb_gso_cb)
>> so that the end of 'cb' is always used.
>> (Assuming the former is a multiple of 4.)
>>
>> It might be worth using an on-stack structure passed through as a separate
>> parameter - it doesn't look as though it has to be queued with the skb.
>> (Clearly a bigger change.)
>
>
> I would definitely prefer the stack structure.
>
> As a kernel developer, sometime I can hardly figure out which struct current
> cb is without debug it, and the worst they are not documented anywhere. I
> can hardly know the life time of the cb types.

NAK.

Skb control block was not designed to be used like a stack but like a union
for different layers, just that people begin to mess it up.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: preserve IP control block during GSO segmentation Konstantin Khlebnikov <koct9i@gmail.com> - 2016-01-08 13:10 +0100
  Re: [PATCH] net: preserve IP control block during GSO segmentation Konstantin Khlebnikov <koct9i@gmail.com> - 2016-01-08 13:20 +0100
  RE: [PATCH] net: preserve IP control block during GSO segmentation David Laight <David.Laight@ACULAB.COM> - 2016-01-08 13:20 +0100
    Re: [PATCH] net: preserve IP control block during GSO segmentation Thadeu Lima de Souza Cascardo <cascardo@redhat.com> - 2016-01-08 13:30 +0100
    Re: [PATCH] net: preserve IP control block during GSO segmentation Zang MingJie <zealot0630@gmail.com> - 2016-01-11 09:20 +0100
      Re: [PATCH] net: preserve IP control block during GSO segmentation Cong Wang <xiyou.wangcong@gmail.com> - 2016-01-12 02:00 +0100
  Re: [PATCH] net: preserve IP control block during GSO segmentation Thadeu Lima de Souza Cascardo <cascardo@redhat.com> - 2016-01-08 13:20 +0100

csiph-web