Re: [PATCH net-next] bonding: make mii_status sysfs node consistent

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next] bonding: make mii_status sysfs node consistent
Date	2016-01-11 23:20 +0100
Message-ID	<qPSYG-bV-7@gated-at.bofh.it> (permalink)
References	<qOQFz-6Is-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Jarod Wilson <jarod@redhat.com>
Date: Fri,  8 Jan 2016 20:35:36 -0500

> The spew in /proc/net/bonding/bond0 uses netif_carrier_ok() to determine
> mii_status, while /sys/class/net/bond0/bonding/mii_status looks at
> curr_active_slave, which doesn't actually seem to be set sometimes when
> the bond actually is up. A mode 4 bond configured via ifcfg-foo files on a
> Red Hat Enterprise Linux system, after boot, comes up clean and
> functional, but the sysfs node shows mii_status of down, while proc shows
> up. A simple enough fix here seems to be to use the same method for
> determining up or down in both places, and I'd opt for the one that seems
> to match reality.
> 
> CC: Jay Vosburgh <j.vosburgh@gmail.com>
> CC: Veaceslav Falico <vfalico@gmail.com>
> CC: Andy Gospodarek <gospo@cumulusnetworks.com>
> CC: netdev@vger.kernel.org
> Signed-off-by: Jarod Wilson <jarod@redhat.com>

Seems reasonable, applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next] bonding: make mii_status sysfs node consistent Jarod Wilson <jarod@redhat.com> - 2016-01-09 02:40 +0100
  Re: [PATCH net-next] bonding: make mii_status sysfs node consistent David Miller <davem@davemloft.net> - 2016-01-11 23:20 +0100

csiph-web