Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1306770

Re: [PATCH 2/2] Use num_possible_cpus() instead of direct use of NR_CPUS.

From Peter Zijlstra <peterz@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] Use num_possible_cpus() instead of direct use of NR_CPUS.
Date 2016-01-11 23:20 +0100
Message-ID <qPSYG-bV-13@gated-at.bofh.it> (permalink)
References <qPpWG-5U9-11@gated-at.bofh.it> <qPL17-34y-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Jan 11, 2016 at 02:46:22PM +0100, Vlastimil Babka wrote:
> On 01/10/2016 04:13 PM, Ameen wrote:
> > WARNING: usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus()..
> 
> Is that a checkpatch warning? Notice the word "often". You need to provide info
> why it's the case here (and I doubt the change will be corect in this case).

Yeah, this is terminally broken.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 2/2] Use num_possible_cpus() instead of direct use of NR_CPUS. Ameen <ameenali023@gmail.com> - 2016-01-10 16:20 +0100
  Re: [PATCH 2/2] Use num_possible_cpus() instead of direct use of  NR_CPUS. Vlastimil Babka <vbabka@suse.cz> - 2016-01-11 14:50 +0100
    Re: [PATCH 2/2] Use num_possible_cpus() instead of direct use of  NR_CPUS. Peter Zijlstra <peterz@infradead.org> - 2016-01-11 23:20 +0100

csiph-web