Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1306617

Re: [PATCH v6] iio: add ad5761 DAC driver

From Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v6] iio: add ad5761 DAC driver
Date 2016-01-11 20:30 +0100
Message-ID <qPQka-6HH-5@gated-at.bofh.it> (permalink)
References <qPNvY-4Q9-23@gated-at.bofh.it> <qPQka-6HH-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hello Jonathan

On Mon, Jan 11, 2016 at 8:24 PM, Jonathan Cameron <jic23@kernel.org> wrote:
> On 11/01/16 16:23, Ricardo Ribalda Delgado wrote:
>> ad5761 is a 1-channel DAC with configurable output range.
>> The driver uses the regulator interface for its voltage ref.
>>
>> It shares its register layout with ad5761r, ad5721 and ad5721r.
>>
>> Differences:
>> ad5761* are 16 bit, ad5721* are 12 bits.
>> ad57*1r have an internal reference.
>>
>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> Just that unnecessary null check left as far as I'm concerned.
> I'd like to leave this a little while for others to take a look
> if they like as well.

Shall i send v7 with that fixed or I wait?


Regards!

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v6] iio: add ad5761 DAC driver Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-01-11 17:30 +0100
  Re: [PATCH v6] iio: add ad5761 DAC driver Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-01-11 20:30 +0100
    Re: [PATCH v6] iio: add ad5761 DAC driver Jonathan Cameron <jic23@kernel.org> - 2016-01-11 20:30 +0100
  Re: [PATCH v6] iio: add ad5761 DAC driver Jonathan Cameron <jic23@kernel.org> - 2016-01-11 20:30 +0100

csiph-web