Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1306509

Re: [PATCH] regulator: max8973: add THERMAL_OF dependency

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Jan 08, 2016 at 09:06:43PM +0100, Arnd Bergmann wrote:

> I've run into the same problem a couple of times now, with every driver
> that calls thermal_zone_of_sensor_register(). I think we need a better
> solution in general, but this fixes the immediate build error for now.

Yes, this doesn't feel very clever especially in this use case where
we're mostly providing data into the thermal framework and not really
relying on it for anything.

> Maybe we should replace the "#ifdef CONFIG_THERMAL_OF" with "#if
> IS_REACHABLE(CONFIG_THERMAL) && IS_ENABLED(CONFIG_THERMAL_OF)"?
> The disadvantage of that is that the thermal management would be
> silently disabled rather than cause a link error, and that may also
> not be desired.

Perhaps we should ensure that at least some glue code is bool rather
than modular?  That's got downsides too, it increases the amount of code
that gets built into the kernel but perhaps that's an acceptable
tradeoff here.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] regulator: max8973: add THERMAL_OF dependency Arnd Bergmann <arnd@arndb.de> - 2016-01-08 21:10 +0100
  Re: [PATCH] regulator: max8973: add THERMAL_OF dependency Mark Brown <broonie@kernel.org> - 2016-01-11 18:00 +0100
  Applied "regulator: max8973: add THERMAL_OF dependency" to the regulator tree Mark Brown <broonie@kernel.org> - 2016-01-11 19:40 +0100

csiph-web