Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1306495

Re: [PATCH] b43: Fix a memory leak in b43_bus_dev_ssb_init

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, 11 Jan 2016 11:37:36 +0800
Jia-Ju Bai <baijiaju1990@163.com> wrote:

> The memory allocated by kzalloc in b43_bus_dev_ssb_init is not freed.
> This patch fixes the bug by adding kfree in b43_ssb_remove.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
> ---
>  drivers/net/wireless/b43/main.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
> index ec013fb..6d251a0 100644
> --- a/drivers/net/wireless/b43/main.c
> +++ b/drivers/net/wireless/b43/main.c
> @@ -5798,6 +5798,7 @@ static void b43_ssb_remove(struct ssb_device *sdev)
>  
>  	b43_leds_unregister(wl);
>  	b43_wireless_exit(dev, wl);
> +	kfree(dev);
>  }
>  
>  static struct ssb_driver b43_ssb_driver = {



Nice catch.
The kfree is also missing in b43_bcma_remove().
And also in the error paths of b43_bcma_probe().

Can you please extend the patch to cover these, too?

-- 
Michael

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] b43: Fix a memory leak in b43_bus_dev_ssb_init Jia-Ju Bai <baijiaju1990@163.com> - 2016-01-11 04:40 +0100
  Re: [PATCH] b43: Fix a memory leak in b43_bus_dev_ssb_init Michael Büsch <m@bues.ch> - 2016-01-11 17:50 +0100
  Re: [PATCH] b43: Fix a memory leak in b43_bus_dev_ssb_init Rafał Miłecki <zajec5@gmail.com> - 2016-01-11 17:50 +0100

csiph-web