Re: [PATCH] ata: add AMD Seattle platform driver

From	Mark Langsdorf <mlangsdo@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ata: add AMD Seattle platform driver
Date	2016-01-11 16:40 +0100
Message-ID	<qPMJA-4ee-5@gated-at.bofh.it> (permalink)
References	<qOqi7-5nl-25@gated-at.bofh.it> <qOstA-6LL-23@gated-at.bofh.it> <qOAUb-4eB-41@gated-at.bofh.it> <qOAUb-4eB-39@gated-at.bofh.it> <qOO14-4T5-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 01/08/2016 04:21 PM, Brijesh Singh wrote:
> Hi,

>> We generally don't refer to register locations with properties other than
>> 'reg', so that approach would be worse. What I'd suggest you do is to
>> have the sgpio registers in a separate device node, and use the LED
>> binding to access it, see
>>
>> Documentation/devicetree/bindings/leds/common.txt
>>
>> It seems that none of the drivers/ata/ drivers use the leds interface
>> today, but that can be added to libata-*.c whenever the appropriate
>> properties are there.
>>
>
> libata-*.c implements the "Enclosure management" style led messages but also has hooks
> to register a custom led control callback. Since Seattle platform does not support
> the "Enclosure management" registers hence ata_port_info we are setting a ATA_FLAG_EM | ATA_FLAG_SW_ACIVITY
> to indicate that we can still handle the led messages by our registered callback. I see
> that sata_highbank driver is doing something similar.

The sata_highbank driver is doing it wrong and shouldn't have been
accepted in its current condition. Enclosure management really should
be a separate device. Please don't use it as an example.

--Mark Langsdorf

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] ata: add AMD Seattle platform driver Arnd Bergmann <arnd@arndb.de> - 2016-01-07 22:30 +0100
  Re: [PATCH] ata: add AMD Seattle platform driver Rob Herring <robh@kernel.org> - 2016-01-08 00:00 +0100
  Re: [PATCH] ata: add AMD Seattle platform driver Arnd Bergmann <arnd@arndb.de> - 2016-01-08 00:50 +0100
    Re: [PATCH] ata: add AMD Seattle platform driver Arnd Bergmann <arnd@arndb.de> - 2016-01-08 09:50 +0100
      Re: [PATCH] ata: add AMD Seattle platform driver Arnd Bergmann <arnd@arndb.de> - 2016-01-08 23:50 +0100
        Re: [PATCH] ata: add AMD Seattle platform driver Arnd Bergmann <arnd@arndb.de> - 2016-01-12 15:30 +0100
          Re: [PATCH] ata: add AMD Seattle platform driver Arnd Bergmann <arnd@arndb.de> - 2016-01-13 21:50 +0100
      Re: [PATCH] ata: add AMD Seattle platform driver Mark Langsdorf <mlangsdo@redhat.com> - 2016-01-11 16:40 +0100

csiph-web