Re: [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors

From	"Shevchenko, Andriy" <andriy.shevchenko@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors
Date	2016-01-11 14:10 +0100
Message-ID	<qPKos-2P4-37@gated-at.bofh.it> (permalink)
References	<qOJkJ-1BX-3@gated-at.bofh.it> <qOJuq-1Gl-1@gated-at.bofh.it> <qPJLJ-2jg-41@gated-at.bofh.it> <qPKeK-2wl-9@gated-at.bofh.it> <qPKeK-2wl-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2016-01-11 at 12:54 +0000, Måns Rullgård wrote:
> "Shevchenko, Andriy" <andriy.shevchenko@intel.com> writes:
> 
> > On Mon, 2016-01-11 at 14:28 +0200, Andy Shevchenko wrote:
> > > On Fri, 2016-01-08 at 18:43 +0100, Anton Wuerfel wrote:
> > > > This patch fixes whitespace errors reported by checkpatch to
> > > > increase
> > > > readability. Main focus is on missing spaces after commas in
> > > > function headers and macros (like foo,bar edited to foo, bar).
> > > > 
> > > > Signed-off-by: Anton Würfel <anton.wuerfel@fau.de>
> > > > Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de>
> > > > CC: linux-kernel@i4.cs.fau.de
> > > 
> > > Cc: looks more standard.
> > > 
> > > > --- a/drivers/tty/serial/8250/8250_accent.c
> > > > +++ b/drivers/tty/serial/8250/8250_accent.c
> > > > @@ -10,7 +10,7 @@
> > > >  #include <linux/init.h>
> > > >  #include <linux/serial_8250.h>
> > > >  
> > > > -#define PORT(_base,_irq)				\
> > > > +#define PORT(_base, _irq)				\
> > > >  	{						\
> > > >  		.iobase		= _base,		
> > > > \
> > > >  		.irq		= _irq,			
> > > > \
> > 
> > 8250_PORT()
> > 
> > > > 
> > > 
> > > While those are okay, I would suggest to make a macro in
> > > drivers/…/8250.h one for all, something like this:
> > > 
> > > #define 8250_PORT_FLAGS(_base, _irq, _flags)
> > > …
> > > 	.flags          = UPF_BOOT_AUTOCONF | (_flags) \
> > > 
> > > #define 8250_PORT(_base, _irq)	8250_PORT_FLAGS(_base,
> > > _irq, 0)
> > > 
> > > And use it.
> > 
> > #define 8250_FOURPORT(_base, _irq)	8250_PORT_FLAGS(_base,
> > _irq,
> > UPF_FOURPORT)
> 
> Macro names can't start with a number.

Oh, right, thanks.

SERIAL8250_PORT* will work.

-- 
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

Thread

[PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors Anton Wuerfel <anton.wuerfel@fau.de> - 2016-01-08 19:00 +0100
  Re: [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-11 13:30 +0100
    Re: [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors Måns Rullgård <mans@mansr.com> - 2016-01-11 14:00 +0100
      Re: [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors "Shevchenko, Andriy" <andriy.shevchenko@intel.com> - 2016-01-11 14:10 +0100
    Re: [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors "Shevchenko, Andriy" <andriy.shevchenko@intel.com> - 2016-01-11 14:00 +0100

csiph-web