Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1306160

Re: [RFC 01/13] x86/paravirt: Turn KASAN off for parvirt.o

From Andrey Ryabinin <aryabinin@virtuozzo.com>
Newsgroups linux.kernel
Subject Re: [RFC 01/13] x86/paravirt: Turn KASAN off for parvirt.o
Date 2016-01-11 14:00 +0100
Message-ID <qPKeK-2wl-3@gated-at.bofh.it> (permalink)
References <qPtxg-8hk-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 01/10/2016 09:59 PM, Borislav Petkov wrote:
> + Andrey.
> 
> On Fri, Jan 08, 2016 at 03:15:19PM -0800, Andy Lutomirski wrote:
>> Otherwise terrible things happen if some of the callbacks end up
>> calling into KASAN in unexpected places.
>>
>> This has no obvious symptoms yet, but adding a memory reference to
>> native_flush_tlb_global without this blows up on KASAN kernels.
>>
>> Signed-off-by: Andy Lutomirski <luto@kernel.org>
>> ---
>>  arch/x86/kernel/Makefile | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile
>> index b1b78ffe01d0..b7cd5bdf314b 100644
>> --- a/arch/x86/kernel/Makefile
>> +++ b/arch/x86/kernel/Makefile
>> @@ -19,6 +19,7 @@ endif
>>  KASAN_SANITIZE_head$(BITS).o := n
>>  KASAN_SANITIZE_dumpstack.o := n
>>  KASAN_SANITIZE_dumpstack_$(BITS).o := n
>> +KASAN_SANITIZE_paravirt.o := n
>>  
>>  CFLAGS_irq.o := -I$(src)/../include/asm/trace
> 
> Shouldn't we take this one irrespectively of what happens to the rest in
> the patchset?
>

I don't think that this patch is the right way to solve the problem.
The follow-up patch "x86/kasan: clear kasan_zero_page after TLB flush" should fix Andy's problem.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC 01/13] x86/paravirt: Turn KASAN off for parvirt.o Andy Lutomirski <luto@kernel.org> - 2016-01-09 00:20 +0100
  Re: [RFC 01/13] x86/paravirt: Turn KASAN off for parvirt.o Borislav Petkov <bp@alien8.de> - 2016-01-10 20:10 +0100
    [PATCH 2/2] x86/kasan: write protect kasan zero shadow Andrey Ryabinin <aryabinin@virtuozzo.com> - 2016-01-11 14:00 +0100
    Re: [RFC 01/13] x86/paravirt: Turn KASAN off for parvirt.o Andrey Ryabinin <aryabinin@virtuozzo.com> - 2016-01-11 14:00 +0100
      [PATCH 1/2] x86/kasan: clear kasan_zero_page after TLB flush Andrey Ryabinin <aryabinin@virtuozzo.com> - 2016-01-11 14:00 +0100

csiph-web