Re: [PATCH v4 12/13] tty: serial: 8250: Removed warning in debug output

From	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 12/13] tty: serial: 8250: Removed warning in debug output
Date	2016-01-11 13:50 +0100
Message-ID	<qPK54-2sM-11@gated-at.bofh.it> (permalink)
References	<qOJkJ-1BX-3@gated-at.bofh.it> <qOJur-1Gl-3@gated-at.bofh.it>
Organization	Intel Finland Oy

Show all headers | View raw

On Fri, 2016-01-08 at 18:43 +0100, Anton Wuerfel wrote:
> This patch fixes type warnings in a debug output in 8250_pnp.c.
> Those warnings never got triggered, because the command was nested
> in an #ifdef, which is removed by a patch of this series.

Would be nice to cite the warning line from compiler or sparse (which
one, btw?)

Also, patch does not fix a warning. Rephrase title and commit message
in an appropriate way.

> 
> Signed-off-by: Anton Würfel <anton.wuerfel@fau.de>
> Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de>
> CC: linux-kernel@i4.cs.fau.de
> ---
>  drivers/tty/serial/8250/8250_pnp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_pnp.c
> b/drivers/tty/serial/8250/8250_pnp.c
> index ba3a1af..e99282f 100644
> --- a/drivers/tty/serial/8250/8250_pnp.c
> +++ b/drivers/tty/serial/8250/8250_pnp.c
> @@ -465,8 +465,8 @@ serial_pnp_probe(struct pnp_dev *dev, const
> struct pnp_device_id *dev_id)
>  		return -ENODEV;
>  
>  	dev_dbg(&dev->dev,
> -		 "Setup PNP port: port %x, mem 0x%lx, irq %d, type
> %d\n",
> -		 uart.port.iobase, uart.port.mapbase,
> +		 "Setup PNP port: port %lx, mem 0x%lx, irq %d, type
> %d\n",
> +		 uart.port.iobase, (unsigned long)
> uart.port.mapbase,

No need to have a space after ).

>  		 uart.port.irq, uart.port.iotype);
>  
>  	if (flags & CIR_PORT) {

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 12/13] tty: serial: 8250: Removed warning in debug output Anton Wuerfel <anton.wuerfel@fau.de> - 2016-01-08 19:00 +0100
  Re: [PATCH v4 12/13] tty: serial: 8250: Removed warning in debug  output Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-11 13:50 +0100

csiph-web