Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1306121
| From | Hannes Frederic Sowa <hannes@stressinduktion.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net] udp: disallow UFO for sockets with SO_NO_CHECK option |
| Date | 2016-01-11 13:20 +0100 |
| Message-ID | <qPJC1-2eG-5@gated-at.bofh.it> (permalink) |
| References | <qPECm-77O-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 11.01.2016 07:50, Michal Kubecek wrote:
> Commit acf8dd0a9d0b ("udp: only allow UFO for packets from SOCK_DGRAM
> sockets") disallows UFO for packets sent from raw sockets. We need to do
> the same also for SOCK_DGRAM sockets with SO_NO_CHECK options, even if
> for a bit different reason: while such socket would override the
> CHECKSUM_PARTIAL set by ip_ufo_append_data(), gso_size is still set and
> bad offloading flags warning is triggered in __skb_gso_segment().
>
> In the IPv6 case, SO_NO_CHECK option is ignored but we need to disallow
> UFO for packets sent by sockets with UDP_NO_CHECK6_TX option.
>
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
> Tested-by: Shannon Nelson <shannon.nelson@intel.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net] udp: disallow UFO for sockets with SO_NO_CHECK option Michal Kubecek <mkubecek@suse.cz> - 2016-01-11 08:00 +0100 Re: [PATCH net] udp: disallow UFO for sockets with SO_NO_CHECK option Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-01-11 13:20 +0100 Re: [PATCH net] udp: disallow UFO for sockets with SO_NO_CHECK option David Miller <davem@davemloft.net> - 2016-01-11 23:50 +0100
csiph-web