RE: [PATCH v2 1/4] PCI: rcar: remove unused pci_sys_data structure in pcie-rcar

From	Phil Edworthy <phil.edworthy@renesas.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH v2 1/4] PCI: rcar: remove unused pci_sys_data structure in pcie-rcar
Date	2016-01-11 12:30 +0100
Message-ID	<qPIPD-1Dk-9@gated-at.bofh.it> (permalink)
References	<qNzx7-3cW-3@gated-at.bofh.it> <qNzx9-3cW-17@gated-at.bofh.it> <qOuvo-83p-1@gated-at.bofh.it> <qOMsi-3Yx-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Bjorn,

On 08 January 2016 21:07, Bjorn Helgaas wrote:
> On Fri, Jan 08, 2016 at 10:50:57AM +0900, Simon Horman wrote:
> > Hi Phil,
> >
> > On Tue, Jan 05, 2016 at 01:00:28PM +0000, Phil Edworthy wrote:
> > > Commit b3a72384fe29 ("ARM/PCI: Replace pci_sys_data->align_resource
> > > with global function pointer") removed the struct pci_sys_data
> > > dependency from the ARM pcibios functions, so remove it from this
> > > driver.
> >
> > I am a little confused by this as I still see two instances of
> > the following in bios32.c as of the commit above.
> >
> > 	struct pci_sys_data *sys = dev->sysdata;
> 
> This patch only removes a pci_sys_data struct from pcie-rcar.c.  That
> struct was previously used by pci_common_init_dev() and by the ARM
> pcibios_align_resource().
> 
> After cbce7900598c ("PCI: designware: Make driver arch-agnostic"), none of
> the DesignWare drivers use pci_common_init_dev(), and after b3a72384fe29,
> ARM doesn't need pci_sys_data for pcibios_align_resource().
> 
> Phil can correct me if I'm wrong, but I think this patch is probably OK.
You are absolutely right!

> I guess we can tell after I apply it and get a build test :)
Yes, it has been built and run on both ARM and ARM64 boards.

Thanks
Phil

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/4] PCI: rcar: remove unused pci_sys_data structure in pcie-rcar Phil Edworthy <phil.edworthy@renesas.com> - 2016-01-05 14:10 +0100
  Re: [PATCH v2 1/4] PCI: rcar: remove unused pci_sys_data structure  in pcie-rcar Simon Horman <horms@verge.net.au> - 2016-01-08 03:00 +0100
    Re: [PATCH v2 1/4] PCI: rcar: remove unused pci_sys_data structure  in pcie-rcar Bjorn Helgaas <helgaas@kernel.org> - 2016-01-08 22:10 +0100
      RE: [PATCH v2 1/4] PCI: rcar: remove unused pci_sys_data structure in  pcie-rcar Phil Edworthy <phil.edworthy@renesas.com> - 2016-01-11 12:30 +0100

csiph-web