Re: [PATCH -next] net: ti: cpmac: Fix build error due to missed API change

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Andrew Lunn <andrew@lunn.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH -next] net: ti: cpmac: Fix build error due to missed API change
Date	Sat, 09 Jan 2016 22:30:02 +0100
Message-ID	<qP9fc-2RT-35@gated-at.bofh.it> (permalink)
References	<qP95w-2NS-19@gated-at.bofh.it>
X-Original-To	Guenter Roeck <linux@roeck-us.net>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	Florian Fainelli <florian@openwrt.org>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Sat, 9 Jan 2016 22:23:47 +0100
X-Original-Message-ID	<20160109212347.GB6877@lunn.ch>
X-Original-References	<1452374379-18644-1-git-send-email-linux@roeck-us.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1305362

Show key headers only | View raw

On Sat, Jan 09, 2016 at 01:19:39PM -0800, Guenter Roeck wrote:
> Commit 7f854420fbfe ("phy: Add API for {un}registering an mdio device to
> a bus") introduces an API to access mii_bus structures, but missed to
> update the TI cpamc driver. This results in the following error message.
> 
> drivers/net/ethernet/ti/cpmac.c: In function 'cpmac_probe':
> drivers/net/ethernet/ti/cpmac.c:1119:18: error:
> 	'struct mii_bus' has no member named 'phy_map'
> 
> Fixes: 7f854420fbfe ("phy: Add API for {un}registering an mdio device to a bus")
> Cc: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Acked-by: Andrew Lunn <andrew@lunn.ch>

Thanks
	Andrew

> ---
>  drivers/net/ethernet/ti/cpmac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c
> index 0b483301767d..7eef45e6d70a 100644
> --- a/drivers/net/ethernet/ti/cpmac.c
> +++ b/drivers/net/ethernet/ti/cpmac.c
> @@ -1116,7 +1116,7 @@ static int cpmac_probe(struct platform_device *pdev)
>  		for (phy_id = 0; phy_id < PHY_MAX_ADDR; phy_id++) {
>  			if (!(pdata->phy_mask & (1 << phy_id)))
>  				continue;
> -			if (!cpmac_mii->phy_map[phy_id])
> +			if (!mdiobus_get_phy(cpmac_mii, phy_id))
>  				continue;
>  			strncpy(mdio_bus_id, cpmac_mii->id, MII_BUS_ID_SIZE);
>  			break;
> -- 
> 2.1.4
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH -next] net: ti: cpmac: Fix build error due to missed API change Guenter Roeck <linux@roeck-us.net> - 2016-01-09 22:20 +0100
  Re: [PATCH -next] net: ti: cpmac: Fix build error due to missed API  change Andrew Lunn <andrew@lunn.ch> - 2016-01-09 22:30 +0100

csiph-web